From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH V3] xfs_io: add mremap command
Date: Sat, 13 Sep 2014 15:12:07 -0500 [thread overview]
Message-ID: <5414A517.1080102@sandeen.net> (raw)
In-Reply-To: <20140913194559.GA28479@infradead.org>
On 9/13/14 2:45 PM, Christoph Hellwig wrote:
> On Fri, Sep 12, 2014 at 11:54:43AM -0500, Eric Sandeen wrote:
>> This adds a simple mremap command to xfs_io.
>>
>> It does not take a start address; it uses the existing
>> start address, so the sized passed will be the new total
>> size of the mapping.
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>
> Looks good to me, but I'd feel much more comfortable about merging it
> if we had an xfstests test case that actually exercises it.
>
I did it for a crazy mremap failure we saw, I'll probably end up
writing a testcase for that which uses it.
I could easily enough write a test to exercise this directly too,
I'll look into it.
Thanks,
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2014-09-13 20:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 3:25 [PATCH] xfs_io: add mremap command Eric Sandeen
2014-09-11 3:29 ` [PATCH V2] " Eric Sandeen
2014-09-12 16:22 ` Eric Sandeen
2014-09-12 16:54 ` [PATCH V3] " Eric Sandeen
2014-09-13 19:45 ` Christoph Hellwig
2014-09-13 20:12 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5414A517.1080102@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox