* [PATCH] libxfs: use structure initializers for cache_operations
@ 2014-09-19 20:44 Eric Sandeen
2014-09-22 13:21 ` Brian Foster
0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2014-09-19 20:44 UTC (permalink / raw)
To: xfs-oss
This makes it a lot easier for cscope etc.
Surely all modern compilers can cope?
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/libxfs/rdwr.c b/libxfs/rdwr.c
index 9ee89d3..80de6fa 100644
--- a/libxfs/rdwr.c
+++ b/libxfs/rdwr.c
@@ -1088,12 +1088,12 @@ libxfs_bcache_overflowed(void)
}
struct cache_operations libxfs_bcache_operations = {
- /* .hash */ libxfs_bhash,
- /* .alloc */ libxfs_balloc,
- /* .flush */ libxfs_bflush,
- /* .relse */ libxfs_brelse,
- /* .compare */ libxfs_bcompare,
- /* .bulkrelse */libxfs_bulkrelse
+ .hash = libxfs_bhash,
+ .alloc = libxfs_balloc,
+ .flush = libxfs_bflush,
+ .relse = libxfs_brelse,
+ .compare = libxfs_bcompare,
+ .bulkrelse = libxfs_bulkrelse
};
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] libxfs: use structure initializers for cache_operations
2014-09-19 20:44 [PATCH] libxfs: use structure initializers for cache_operations Eric Sandeen
@ 2014-09-22 13:21 ` Brian Foster
0 siblings, 0 replies; 2+ messages in thread
From: Brian Foster @ 2014-09-22 13:21 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs-oss
On Fri, Sep 19, 2014 at 03:44:33PM -0500, Eric Sandeen wrote:
> This makes it a lot easier for cscope etc.
>
> Surely all modern compilers can cope?
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
Seems reasonable to me.
Reviewed-by: Brian Foster <bfoster@redhat.com>
>
> diff --git a/libxfs/rdwr.c b/libxfs/rdwr.c
> index 9ee89d3..80de6fa 100644
> --- a/libxfs/rdwr.c
> +++ b/libxfs/rdwr.c
> @@ -1088,12 +1088,12 @@ libxfs_bcache_overflowed(void)
> }
>
> struct cache_operations libxfs_bcache_operations = {
> - /* .hash */ libxfs_bhash,
> - /* .alloc */ libxfs_balloc,
> - /* .flush */ libxfs_bflush,
> - /* .relse */ libxfs_brelse,
> - /* .compare */ libxfs_bcompare,
> - /* .bulkrelse */libxfs_bulkrelse
> + .hash = libxfs_bhash,
> + .alloc = libxfs_balloc,
> + .flush = libxfs_bflush,
> + .relse = libxfs_brelse,
> + .compare = libxfs_bcompare,
> + .bulkrelse = libxfs_bulkrelse
> };
>
>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-09-22 13:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-09-19 20:44 [PATCH] libxfs: use structure initializers for cache_operations Eric Sandeen
2014-09-22 13:21 ` Brian Foster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox