[PATCH] libxfs: use structure initializers for cache_operations

[PATCH] libxfs: use structure initializers for cache_operations

[Eric Sandeen]

This makes it a lot easier for cscope etc.

Surely all modern compilers can cope?

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

diff --git a/libxfs/rdwr.c b/libxfs/rdwr.c
index 9ee89d3..80de6fa 100644
--- a/libxfs/rdwr.c
+++ b/libxfs/rdwr.c
@@ -1088,12 +1088,12 @@ libxfs_bcache_overflowed(void)
 }
 
 struct cache_operations libxfs_bcache_operations = {
-	/* .hash */	libxfs_bhash,
-	/* .alloc */	libxfs_balloc,
-	/* .flush */	libxfs_bflush,
-	/* .relse */	libxfs_brelse,
-	/* .compare */	libxfs_bcompare,
-	/* .bulkrelse */libxfs_bulkrelse
+	.hash		= libxfs_bhash,
+	.alloc		= libxfs_balloc,
+	.flush		= libxfs_bflush,
+	.relse		= libxfs_brelse,
+	.compare	= libxfs_bcompare,
+	.bulkrelse	= libxfs_bulkrelse
 };
 
 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] libxfs: use structure initializers for cache_operations

[Brian Foster]

On Fri, Sep 19, 2014 at 03:44:33PM -0500, Eric Sandeen wrote:
> This makes it a lot easier for cscope etc.
> 
> Surely all modern compilers can cope?
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---

Seems reasonable to me.

Reviewed-by: Brian Foster <bfoster@redhat.com>

> 
> diff --git a/libxfs/rdwr.c b/libxfs/rdwr.c
> index 9ee89d3..80de6fa 100644
> --- a/libxfs/rdwr.c
> +++ b/libxfs/rdwr.c
> @@ -1088,12 +1088,12 @@ libxfs_bcache_overflowed(void)
>  }
>  
>  struct cache_operations libxfs_bcache_operations = {
> -	/* .hash */	libxfs_bhash,
> -	/* .alloc */	libxfs_balloc,
> -	/* .flush */	libxfs_bflush,
> -	/* .relse */	libxfs_brelse,
> -	/* .compare */	libxfs_bcompare,
> -	/* .bulkrelse */libxfs_bulkrelse
> +	.hash		= libxfs_bhash,
> +	.alloc		= libxfs_balloc,
> +	.flush		= libxfs_bflush,
> +	.relse		= libxfs_brelse,
> +	.compare	= libxfs_bcompare,
> +	.bulkrelse	= libxfs_bulkrelse
>  };
>  
>  
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs