public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Stan Hoeppner <stan@hardwarefreak.com>, xfs@oss.sgi.com
Subject: Re: makefs alignment issue
Date: Sat, 25 Oct 2014 10:51:22 -0500	[thread overview]
Message-ID: <544BC6FA.8090101@sandeen.net> (raw)
In-Reply-To: <544B1439.6060509@hardwarefreak.com>

On 10/24/14 10:08 PM, Stan Hoeppner wrote:
> On 10/24/2014 05:27 PM, Eric Sandeen wrote:
>> On 10/24/14 5:19 PM, Eric Sandeen wrote:
>>> On 10/24/14 5:08 PM, Stan Hoeppner wrote:
>>>>
>>>> On 10/24/2014 03:14 PM, Eric Sandeen wrote:
>>>
>>> ...
>>>
>>>>>> Any ideas how to verify what's going on here and fix it?
>>>>>
>>>>> # blockdev --getiomin --getioopt /dev/s2d_a1l003
>>
>> Also, what does it show for the underlying non-multipath device(s)?
> 
> # blockdev --getiomin --getioopt /dev/sdj
> 512
> 1048576
> # blockdev --getiomin --getioopt /dev/sdf
> 512
> 1048576

Ok, so dm multipath is just bubbling up what the device itself
is claiming; not dm's doing.

I forgot to ask (and you forgot to report...!) what version
of xfsprogs you're using....

Currently, blkid_get_topology() in xfsprogs does:

        /*
         * Blkid reports the information in terms of bytes, but we want it in
         * terms of 512 bytes blocks (just to convert it to bytes later..)
         *
         * If the reported values are the same as the physical sector size
         * do not bother to report anything.  It will just cause warnings
         * if people specify larger stripe units or widths manually.
         */
        val = blkid_topology_get_minimum_io_size(tp);
        if (val > *psectorsize)
                *sunit = val >> 9;
        val = blkid_topology_get_optimal_io_size(tp);
        if (val > *psectorsize)
                *swidth = val >> 9;

so in your case sunit probably wouldn't get set (can you confirm with
# blockdev --getpbsz that the physical sector size is also 512?)

But the optimal size is > physical sector so swidth gets set.

Bleah...  can you just collect all of:

# blockdev --getpbsz --getss --getiomin --getioopt

for your underlying devices, and I'll dig into how xfsprogs is behaving for
those values.  I have a hunch that we should be ignoring stripe units of 512
even if the "width" claims to be something larger.

-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2014-10-25 15:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-24 20:11 makefs alignment issue Stan Hoeppner
2014-10-24 20:14 ` Eric Sandeen
2014-10-24 22:08   ` Stan Hoeppner
2014-10-24 22:19     ` Eric Sandeen
2014-10-24 22:27       ` Eric Sandeen
2014-10-25  3:08         ` Stan Hoeppner
2014-10-25 15:51           ` Eric Sandeen [this message]
2014-10-25 17:35             ` Stan Hoeppner
2014-10-26 23:43               ` Dave Chinner
2014-10-27 23:04                 ` Stan Hoeppner
2014-10-28  0:32                   ` Dave Chinner
2014-10-28 16:55                     ` Stan Hoeppner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=544BC6FA.8090101@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=stan@hardwarefreak.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox