From: Eric Sandeen <sandeen@sandeen.net>
To: Brian Foster <bfoster@redhat.com>
Cc: Eric Sandeen <sandeen@redhat.com>,
Stan Hoeppner <stan@hardwarefreak.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH 2/2] xfsprogs: don't warn about log sunit size if it was auto-discovered
Date: Wed, 29 Oct 2014 13:45:40 -0500 [thread overview]
Message-ID: <545135D4.6010908@sandeen.net> (raw)
In-Reply-To: <20141029183841.GB4226@bfoster.laptop>
On 10/29/14 1:38 PM, Brian Foster wrote:
> On Tue, Oct 28, 2014 at 12:38:05PM -0500, Eric Sandeen wrote:
>> Today, users doing a bare mkfs on storage with a large default
>> stripe size may be surprised to get this warning:
>>
>> log stripe unit (%d bytes) is too large (maximum is 256KiB
>> log stripe unit adjusted to 32KiB
>>
>> through no fault of their own. The fallback is appropriate
>> and harmless, and there's no need to warn about this in the
>> defaults case.
>>
>> However, we keep the warning if a large log stripe unit was
>> specified by the user on the commandline.
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>> ---
...
>> @@ -2379,11 +2383,15 @@ an AG size that is one stripe unit smaller, for example %llu.\n"),
>> }
>>
>> if (logversion == 2 && (lsunit * blocksize) > 256 * 1024) {
>> - fprintf(stderr,
>> + /* Warn only if specified on commandline */
>> + if (lsuflag || lsunitflag) {
>> + fprintf(stderr,
>> _("log stripe unit (%d bytes) is too large (maximum is 256KiB)\n"),
>> - (lsunit * blocksize));
>> + (lsunit * blocksize));
>> + fprintf(stderr,
>> + _("log stripe unit adjusted to 32KiB\n"));
>> + }
>
> Right above this particular hunk we have the possibility of lsunit
> inheriting a value from dsunit. If the latter is specified by the user,
> we don't print the message for an arguably user-specified lsunit. Hmm,
> do we care about that case?
I don't think we do care. I think we only care if the user manually
specified a log stripe unit and we're changing what they asked for.
I'd put "inheritance" in the "using default behaviors" case, and not
warn about it.
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-10-29 18:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 17:35 [PATCH 1/2] xfsprogs: ignore stripe geom if sunit or swidth == physical sector size Eric Sandeen
2014-10-28 17:38 ` [PATCH 2/2] xfsprogs: don't warn about log sunit size if it was auto-discovered Eric Sandeen
2014-10-29 18:38 ` Brian Foster
2014-10-29 18:45 ` Eric Sandeen [this message]
2014-10-29 19:57 ` Brian Foster
2014-10-29 18:37 ` [PATCH 1/2] xfsprogs: ignore stripe geom if sunit or swidth == physical sector size Brian Foster
2014-10-29 18:47 ` Eric Sandeen
2014-10-29 21:38 ` Stan Hoeppner
2014-10-30 11:46 ` Brian Foster
2014-10-30 19:15 ` Stan Hoeppner
2014-10-30 19:50 ` Brian Foster
2014-10-30 20:15 ` Stan Hoeppner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545135D4.6010908@sandeen.net \
--to=sandeen@sandeen.net \
--cc=bfoster@redhat.com \
--cc=sandeen@redhat.com \
--cc=stan@hardwarefreak.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox