Re: [PATCH v7 00/15] io-uring/xfs: support async buffered writes

Dave Chinner
2022-06-03T02:43:38Z

On Thu, Jun 02, 2022 at 02:09:00AM -0600, Jens Axboe wrote:
> On 6/1/22 3:01 PM, Stefan Roesch wrote:
> > This patch series adds support for async buffered writes when using both
> > xfs and io-uring. Currently io-uring only supports buffered writes in the
> > slow path, by processing them in the io workers. With this patch series it is
> > now possible to support buffered writes in the fast path. To be able to use
> > the fast path the required pages must be in the page cache, the required locks
> > in xfs can be granted immediately and no additional blocks need to be read
> > form disk.
>
> This series looks good to me now, but will need some slight rebasing
> since the 5.20 io_uring branch has split up the code a bit. Trivial to
> do though, I suspect it'll apply directly if we just change
> fs/io_uring.c to io_uring/rw.c instead.
>
> The bigger question is how to stage this, as it's touching a bit of fs,
> mm, and io_uring...

What data integrity testing has this had? Has it been run through a
few billion fsx operations with w/ io_uring read/write enabled?

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com