From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 4539A7F37 for ; Thu, 13 Nov 2014 12:10:06 -0600 (CST) Message-ID: <5464F3F9.10305@sgi.com> Date: Thu, 13 Nov 2014 12:10:01 -0600 From: Mark Tinguely MIME-Version: 1.0 Subject: Re: [PATCH 9/9] xfsdump: fix uninit ackstr in content_mediachange_query() References: <1415818638-32700-1-git-send-email-sandeen@redhat.com> <1415818638-32700-10-git-send-email-sandeen@redhat.com> In-Reply-To: <1415818638-32700-10-git-send-email-sandeen@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Eric Sandeen Cc: xfs@oss.sgi.com On 11/12/14 12:57, Eric Sandeen wrote: > Today, this sends an uninitialized ackstr[0] to be mlog'd - > who knows what we get out of it. Other places follow this > "count = 0, string = "\n"" pattern which seemsa bit odd, but > better than printing uninitialized memory. > > To be completely honest, I have no test for this. > > Signed-off-by: Eric Sandeen > --- > restore/content.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/restore/content.c b/restore/content.c > index c99aed7..bc5b398 100644 > --- a/restore/content.c > +++ b/restore/content.c > @@ -2915,6 +2915,7 @@ content_mediachange_query( void ) > bagp = 0; > } > ackcnt = 0; > + ackstr[ ackcnt++ ] = "\n"; > dlog_multi_ack( ackstr, > ackcnt ); > querycnt = 0; dlog_multi_ack() with count of 0 will exit without doing anything. Looks like some conditional code that filled the ackstr array (like the other callers) was removed. I vote to pull ackstr, ackcnt and the dlog_multi_ack() from this function. --Mark. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs