From: Mark Tinguely <tinguely@sgi.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: lobotomise xfs_trans_read_buf_map()
Date: Wed, 03 Dec 2014 08:09:50 -0600 [thread overview]
Message-ID: <547F19AE.6050808@sgi.com> (raw)
In-Reply-To: <20141203105122.GA3727@infradead.org>
On 12/03/14 04:51, Christoph Hellwig wrote:
> On Wed, Dec 03, 2014 at 09:45:18AM +1100, Dave Chinner wrote:
>>> Can you fix the inconsistent return for the trylock case in a follow on
>>> patch? This difference doesn't look intentional to me, and I would
>>> be surprised if it's correctly handled in the callers.
>>
>> Ok, I'll do an audit and make this common in a follow up patch. Just
>> to confirm:
>>
>> if (!(flags & XBF_TRYLOCK))
>> return -ENOMEM;
>> return -EAGAIN;
>>
>> is what you want to see, right?
>
> Yes.
Even ENOMEM / EAGAIN could be wrong if _xfs_buf_find() was given an
illegal block number - then it would be EFSCORRUPT.
I think we need to push the error message from _xfs_buf_find(). I played
with it once and seemed to have lost it and can do it again if no one
else has the time.
--Mark.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-12-03 14:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 22:34 [PATCH] xfs: lobotomise xfs_trans_read_buf_map() Dave Chinner
2014-12-02 16:59 ` Christoph Hellwig
2014-12-02 22:45 ` Dave Chinner
2014-12-02 23:07 ` [PATCH v2] " Dave Chinner
2014-12-03 10:53 ` Christoph Hellwig
2014-12-03 10:51 ` [PATCH] " Christoph Hellwig
2014-12-03 14:09 ` Mark Tinguely [this message]
2014-12-03 19:54 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547F19AE.6050808@sgi.com \
--to=tinguely@sgi.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox