From: Eric Sandeen <sandeen@sandeen.net>
To: Dave Chinner <david@fromorbit.com>, xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: remove deprecated sysctls
Date: Wed, 07 Jan 2015 15:48:38 -0600 [thread overview]
Message-ID: <54ADA9B6.9010303@sandeen.net> (raw)
In-Reply-To: <1420667006-7377-1-git-send-email-david@fromorbit.com>
On 1/7/15 3:43 PM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> xfsbufd_centisecs and age_buffer_centisecs were due for removal in
> 3.14. We forgot to do that - it's now well past time to remove these
> deprecated, unused sysctls.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
> Documentation/filesystems/xfs.txt | 17 +++++++----------
> fs/xfs/xfs_sysctl.c | 18 ------------------
> 2 files changed, 7 insertions(+), 28 deletions(-)
>
> diff --git a/Documentation/filesystems/xfs.txt b/Documentation/filesystems/xfs.txt
> index 5be51fd..7077103 100644
> --- a/Documentation/filesystems/xfs.txt
> +++ b/Documentation/filesystems/xfs.txt
> @@ -348,16 +348,13 @@ The following sysctls are available for the XFS filesystem:
> Deprecated Sysctls
> ==================
>
> - fs.xfs.xfsbufd_centisecs (Min: 50 Default: 100 Max: 3000)
> - Dirty metadata is now tracked by the log subsystem and
> - flushing is driven by log space and idling demands. The
> - xfsbufd no longer exists, so this syctl does nothing.
> +None at present.
>
> - Due for removal in 3.14.
>
> - fs.xfs.age_buffer_centisecs (Min: 100 Default: 1500 Max: 720000)
> - Dirty metadata is now tracked by the log subsystem and
> - flushing is driven by log space and idling demands. The
> - xfsbufd no longer exists, so this syctl does nothing.
> +Removed Sysctls
> +===============
>
> - Due for removal in 3.14.
> + Name Removed
> + ---- -------
> + fs.xfs.xfsbufd_centisec v3.20
> + fs.xfs.age_buffer_centisecs v3.20
> diff --git a/fs/xfs/xfs_sysctl.c b/fs/xfs/xfs_sysctl.c
> index 1743b9f..a0c8067 100644
> --- a/fs/xfs/xfs_sysctl.c
> +++ b/fs/xfs/xfs_sysctl.c
> @@ -149,24 +149,6 @@ static struct ctl_table xfs_table[] = {
> .extra2 = &xfs_params.inherit_noatim.max
> },
> {
> - .procname = "xfsbufd_centisecs",
> - .data = &xfs_params.xfs_buf_timer.val,
> - .maxlen = sizeof(int),
> - .mode = 0644,
> - .proc_handler = proc_dointvec_minmax,
> - .extra1 = &xfs_params.xfs_buf_timer.min,
> - .extra2 = &xfs_params.xfs_buf_timer.max
> - },
> - {
> - .procname = "age_buffer_centisecs",
> - .data = &xfs_params.xfs_buf_age.val,
> - .maxlen = sizeof(int),
> - .mode = 0644,
> - .proc_handler = proc_dointvec_minmax,
> - .extra1 = &xfs_params.xfs_buf_age.min,
> - .extra2 = &xfs_params.xfs_buf_age.max
> - },
> - {
> .procname = "inherit_nosymlinks",
> .data = &xfs_params.inherit_nosym.val,
> .maxlen = sizeof(int),
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-01-07 21:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 21:43 [PATCH] xfs: remove deprecated sysctls Dave Chinner
2015-01-07 21:48 ` Eric Sandeen [this message]
2015-01-09 13:48 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54ADA9B6.9010303@sandeen.net \
--to=sandeen@sandeen.net \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox