From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 29E537FA7 for ; Wed, 7 Jan 2015 15:48:42 -0600 (CST) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay2.corp.sgi.com (Postfix) with ESMTP id 16941304043 for ; Wed, 7 Jan 2015 13:48:41 -0800 (PST) Received: from sandeen.net (sandeen.net [63.231.237.45]) by cuda.sgi.com with ESMTP id c2NRcZY0ZuD1dRh4 for ; Wed, 07 Jan 2015 13:48:40 -0800 (PST) Message-ID: <54ADA9B6.9010303@sandeen.net> Date: Wed, 07 Jan 2015 15:48:38 -0600 From: Eric Sandeen MIME-Version: 1.0 Subject: Re: [PATCH] xfs: remove deprecated sysctls References: <1420667006-7377-1-git-send-email-david@fromorbit.com> In-Reply-To: <1420667006-7377-1-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Dave Chinner , xfs@oss.sgi.com On 1/7/15 3:43 PM, Dave Chinner wrote: > From: Dave Chinner > Reviewed-by: Eric Sandeen > xfsbufd_centisecs and age_buffer_centisecs were due for removal in > 3.14. We forgot to do that - it's now well past time to remove these > deprecated, unused sysctls. > > Signed-off-by: Dave Chinner > --- > Documentation/filesystems/xfs.txt | 17 +++++++---------- > fs/xfs/xfs_sysctl.c | 18 ------------------ > 2 files changed, 7 insertions(+), 28 deletions(-) > > diff --git a/Documentation/filesystems/xfs.txt b/Documentation/filesystems/xfs.txt > index 5be51fd..7077103 100644 > --- a/Documentation/filesystems/xfs.txt > +++ b/Documentation/filesystems/xfs.txt > @@ -348,16 +348,13 @@ The following sysctls are available for the XFS filesystem: > Deprecated Sysctls > ================== > > - fs.xfs.xfsbufd_centisecs (Min: 50 Default: 100 Max: 3000) > - Dirty metadata is now tracked by the log subsystem and > - flushing is driven by log space and idling demands. The > - xfsbufd no longer exists, so this syctl does nothing. > +None at present. > > - Due for removal in 3.14. > > - fs.xfs.age_buffer_centisecs (Min: 100 Default: 1500 Max: 720000) > - Dirty metadata is now tracked by the log subsystem and > - flushing is driven by log space and idling demands. The > - xfsbufd no longer exists, so this syctl does nothing. > +Removed Sysctls > +=============== > > - Due for removal in 3.14. > + Name Removed > + ---- ------- > + fs.xfs.xfsbufd_centisec v3.20 > + fs.xfs.age_buffer_centisecs v3.20 > diff --git a/fs/xfs/xfs_sysctl.c b/fs/xfs/xfs_sysctl.c > index 1743b9f..a0c8067 100644 > --- a/fs/xfs/xfs_sysctl.c > +++ b/fs/xfs/xfs_sysctl.c > @@ -149,24 +149,6 @@ static struct ctl_table xfs_table[] = { > .extra2 = &xfs_params.inherit_noatim.max > }, > { > - .procname = "xfsbufd_centisecs", > - .data = &xfs_params.xfs_buf_timer.val, > - .maxlen = sizeof(int), > - .mode = 0644, > - .proc_handler = proc_dointvec_minmax, > - .extra1 = &xfs_params.xfs_buf_timer.min, > - .extra2 = &xfs_params.xfs_buf_timer.max > - }, > - { > - .procname = "age_buffer_centisecs", > - .data = &xfs_params.xfs_buf_age.val, > - .maxlen = sizeof(int), > - .mode = 0644, > - .proc_handler = proc_dointvec_minmax, > - .extra1 = &xfs_params.xfs_buf_age.min, > - .extra2 = &xfs_params.xfs_buf_age.max > - }, > - { > .procname = "inherit_nosymlinks", > .data = &xfs_params.inherit_nosym.val, > .maxlen = sizeof(int), > _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs