Re: xfs_logprint segfault with external log

[Alexander Tsvetkov <alexander.tsvetkov@oracle.com>]

On 02/13/2015 02:09 AM, Dave Chinner wrote:
> On Thu, Feb 12, 2015 at 02:52:45PM +0300, Alexander Tsvetkov wrote:
>> On 02/11/2015 11:54 PM, Dave Chinner wrote:
>>> On Wed, Feb 11, 2015 at 04:51:44PM +0300, Alexander Tsvetkov wrote:
>>>> Hello,
>>>>
>>>> I've obtained corrupted xfs log after some sanity xfs testing:
>>>>
>>>> "log=logfile
>>>> log_size=855
>>>>
>>>> dd if=/dev/zero "of=$log" bs=4096 count=$log_size
>>>> loopdev=$(losetup -f)
>>>> losetup $loopdev $log
>>>>
>>>> mkfs.xfs -f -m crc=1 -llogdev=$loopdev,size=${log_size}b $SCRATCH_DEV
>>>> mount -t xfs -ologdev=$loopdev $SCRATCH_DEV $SCRATCH_MNT
>>>> ./fdtree.sh  -l 4 -d 4 -C -o $SCRATCH_MNT
>>>> sync
>>>> umount $SCRATCH_MNT
>>>>
>>>> xfs_logprint -l $loopdev $SCRATCH_DEV"
>>>>
>>>> Test makes crc enabled xfs filesystem with the external log of
>>>> minimal allowed size and then creates on this fs the small directory
>>>> tree
>>>> with sub directories and files of fixed depth and size with help of
>>>> fdtree utility:
>>>> https://computing.llnl.gov/?set=code&page=sio_downloads
>>> Just take metadump image and put it somewhere we can down load it.
>>>
>>>> After that xfs_logprint stably reports bad data in log:
> Please try the patch below, it fixes the problem on the image you
> provided.

I've restored provided image to filesystem with the same log file, 
applied patch to latest xfsprogs and have stable pass runs
of xfs_logprint on that filesystem and running with xfsprogs without 
this patch results to xfs_logprint segfaults reported that means patch 
is working.
The problem that it is not working for repeated test runs where 
xfs_logprint still continue to report bad log data. It seems it is 
working for some
cases including this image, because sometimes test can be passed but 
most part of test runs have still this xfs_logprint log error. Here is 
another fs image
that is still failed for me with patch applied to xfsprogs: 
https://drive.google.com/file/d/0B1Cg0_B_ui2gM1Bzdkc3TWVqbGM/view?usp=sharing


> Cheers,
>
> Dave.
Thanks,
Alexander Tsvetkov

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs