From: Eric Sandeen <sandeen@sandeen.net>
To: Brian Foster <bfoster@redhat.com>, Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: Introduce permanent async buffer write IO failures
Date: Thu, 19 Feb 2015 15:41:12 -0600 [thread overview]
Message-ID: <54E65878.2000302@sandeen.net> (raw)
In-Reply-To: <20150219142842.GA2291@laptop.bfoster>
On 2/19/15 8:28 AM, Brian Foster wrote:
> On Thu, Feb 19, 2015 at 09:32:20AM +1100, Dave Chinner wrote:
...
>> + if (!(bp->b_flags & (XBF_STALE|XBF_WRITE_FAIL))) {
>> + bp->b_flags |= XBF_WRITE | XBF_ASYNC |
>> + XBF_DONE | XBF_WRITE_FAIL;
>> + xfs_buf_submit(bp);
>> + return true;
so, shouldn't
xfs_buf_ioerror(bp, 0);
go under this conditional to address Brian's point... ok, you just responded to that. :)
FWIW, this is re-setting XBF_ASYNC which must already be set, right?
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-02-19 21:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 22:32 [PATCH] xfs: Introduce permanent async buffer write IO failures Dave Chinner
2015-02-18 23:14 ` Eric Sandeen
2015-02-18 23:52 ` Dave Chinner
2015-02-19 19:04 ` Carlos Maiolino
2015-02-19 21:18 ` Dave Chinner
2015-02-19 14:28 ` Brian Foster
2015-02-19 21:34 ` Dave Chinner
2015-02-19 21:41 ` Eric Sandeen [this message]
2015-02-19 23:02 ` Dave Chinner
2015-02-19 22:39 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E65878.2000302@sandeen.net \
--to=sandeen@sandeen.net \
--cc=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox