From: Eric Sandeen <sandeen@sandeen.net>
To: xfs-oss <xfs@oss.sgi.com>
Cc: Carlos Maiolino <cmaiolin@redhat.com>
Subject: [PATCH 1/2] xfs: Ensure we have target_ip for RENAME_EXCHANGE
Date: Mon, 23 Feb 2015 12:59:11 -0600 [thread overview]
Message-ID: <54EB787F.5090600@sandeen.net> (raw)
In-Reply-To: <54EB782F.8020201@redhat.com>
We shouldn't get here with RENAME_EXCHANGE set and no
target_ip, but let's be defensive, because xfs_cross_rename()
will dereference it.
Spotted by Coverity.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
index daafa1f..6163767 100644
--- a/fs/xfs/xfs_inode.c
+++ b/fs/xfs/xfs_inode.c
@@ -2867,6 +2867,10 @@ xfs_rename(
* Handle RENAME_EXCHANGE flags
*/
if (flags & RENAME_EXCHANGE) {
+ if (target_ip == NULL) {
+ error = -EINVAL;
+ goto error_return;
+ }
error = xfs_cross_rename(tp, src_dp, src_name, src_ip,
target_dp, target_name, target_ip,
&free_list, &first_block, spaceres);
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-02-23 18:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 18:57 [PATCH 0/2] Fix a couple coverity-spotted issues Eric Sandeen
2015-02-23 18:59 ` Eric Sandeen [this message]
2015-02-23 20:48 ` [PATCH 1/2] xfs: Ensure we have target_ip for RENAME_EXCHANGE Christoph Hellwig
2015-02-23 19:00 ` [PATCH 2/2] xfs: cancel failed transaction in xfs_fs_commit_blocks() Eric Sandeen
2015-02-23 20:48 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EB787F.5090600@sandeen.net \
--to=sandeen@sandeen.net \
--cc=cmaiolin@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox