Re: [PATCH 2/2] xfs: cancel failed transaction in xfs_fs_commit_blocks()

Christoph Hellwig
2015-02-23T20:48:39Z

On Mon, Feb 23, 2015 at 01:00:27PM -0600, Eric Sandeen wrote:
> If xfs_trans_reserve fails we don't cancel the transaction,
> and we'll leak the allocated transaction pointer.
>
> Spotted by Coverity.

Thanks, looks good.

Reviewed-by: Christoph Hellwig <hch@lst.de>