From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id AE1087F3F for ; Thu, 5 Mar 2015 14:09:00 -0600 (CST) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay2.corp.sgi.com (Postfix) with ESMTP id 9C9EB30406A for ; Thu, 5 Mar 2015 12:08:57 -0800 (PST) Received: from sandeen.net (sandeen.net [63.231.237.45]) by cuda.sgi.com with ESMTP id bwtC4jUBrVG7VH5W for ; Thu, 05 Mar 2015 12:08:55 -0800 (PST) Message-ID: <54F8B7D6.2000501@sandeen.net> Date: Thu, 05 Mar 2015 14:08:54 -0600 From: Eric Sandeen MIME-Version: 1.0 Subject: Re: trying to avoid a lengthy quotacheck by deleting all quota data References: <54EC958E.2000001@pythonanywhere.com> <20150224215907.GA18360@dastard> <54EF1A8F.7030505@pythonanywhere.com> <54F856E7.10006@pythonanywhere.com> <54F87BF3.3000405@sandeen.net> <54F88CEC.4030009@pythonanywhere.com> <54F89201.60805@sandeen.net> <54F893AF.2070406@pythonanywhere.com> <54F895FA.4050205@sandeen.net> <54F89B47.4010702@pythonanywhere.com> In-Reply-To: <54F89B47.4010702@pythonanywhere.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Harry , xfs@oss.sgi.com On 3/5/15 12:07 PM, Harry wrote: > Here's the syslog, if you're curious. > > http://pastebin.com/raw.php?i=kKvWJcze > > Search for "Failed to initialize" Ok, there is no other message offering more info, sadly. > So your best guess is that it's the drbd layer that's causing the > quotacheck? Out of curiosity, i may try mounting a non-drbd drive > with xfs, and seeing if we can still repro the > hard-reboot-causes-quotacheck thing... Unless you think it's just an > old behaviour that's more to do with the version of the kernel we're > using? I really don't have a good guess at this point..... oh, wait, finally, a bell goes off: commit 5ef828c4152726f56751c78ea844f08d2b2a4fa3 Author: Eric Sandeen Date: Mon Aug 4 11:35:44 2014 +1000 xfs: avoid false quotacheck after unclean shutdown The commit 83e782e xfs: Remove incore use of XFS_OQUOTA_ENFD and XFS_OQUOTA_CHKD added a new function xfs_sb_quota_from_disk() which swaps on-disk XFS_OQUOTA_* flags for in-core XFS_GQUOTA_* and XFS_PQUOTA_* flags after the superblock is read. However, if log recovery is required, the superblock is read again, and the modified in-core flags are re-read from disk, so we have XFS_OQUOTA_* flags in memory again. This causes the XFS_QM_NEED_QUOTACHECK() test to be true, because the XFS_OQUOTA_CHKD is still set, and not XFS_GQUOTA_CHKD or XFS_PQUOTA_CHKD. Change xfs_sb_from_disk to call xfs_sb_quota_from disk and always convert the disk flags to in-memory flags. Add a lower-level function which can be called with "false" to not convert the flags, so that the sb verifier can verify exactly what was on disk, per Brian Foster's suggestion. Reported-by: Cyril B. Signed-off-by: Eric Sandeen 83e782e went in at v3.11; the above commit hit v3.17, so it was broken for a while. I still can't explain the "quota init failed" bit, but the above probably explains the unexpected quotacheck problem. -Eric > HP _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs