Re: [PATCH 1/4] xfs_repair: dirty inode in process_sf_dir2 if we change namelen

Brian Foster
2015-03-13T14:34:25Z

On Tue, Mar 10, 2015 at 04:55:59PM -0400, Eric Sandeen wrote:
> There are two "fix sfep->namelen" cases, but we only mark
> *dino_dirty = 1 in one of them. Add the other to ensure that
> the change gets written out.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---

Reviewed-by: Brian Foster <bfoster@redhat.com>

>
> diff --git a/repair/dir2.c b/repair/dir2.c
> index 6b8964d..25793e9 100644
> --- a/repair/dir2.c
> +++ b/repair/dir2.c
> @@ -881,6 +881,7 @@ _("entry \"%*.*s\" in shortform directory %" PRIu64 " references %s inode %" PRI
> _("zero length entry in shortform dir %" PRIu64 ", resetting to %d\n"),
> ino, namelen);
> sfep->namelen = namelen;
> + *dino_dirty = 1;
> } else {
> do_warn(
> _("zero length entry in shortform dir %" PRIu64 ", would set to %d\n"),
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs