Re: [PATCH 0/5 V2] xfs: RENAME_WHITEOUT support

Brian Foster
2015-03-24T19:41:22Z

On Tue, Mar 24, 2015 at 09:59:26PM +1100, Dave Chinner wrote:
> Hi folks,
>
> This is the second version of the RENAME_WHITEOUT patchset that I
> originally posted here:
>
> http://oss.sgi.com/pipermail/xfs/2015-February/040378.html
>
> This is mainly the breakup and restructuring of the patchset I
> mention that needed to be done, as well as addressing the comments
> that were made at the time (e.g. wino -> wip).
>
> The patchset has been split into 5 patches, the first four are
> really cleanup and factoring patches to make the rename and inode
> locking code a bit simpler and easier to understand. The last patch
> then introduces the RENAME_WHITEOUT functionality, which ends up
> being surprisingly little code....
>
> The changes pass xfstests, but I have not run them on overlayfs at
> all yet, so I don't know if that's going to result in smoke and
> tears yet. Still, getting the patch set out for review now is more
> important that waiting for testing because there is relatively
> little time left before the 4.1 merge window opens up....
>
> So, comments, thoughts and flames are more than welcome.
>

These all look pretty good to me. I ran a quick rename test on top of
overlayfs as well and it seems to do what it's supposed to (e.g., rename
of a file on the lower dir is hidden via whiteout on the upper). For the
set...

Reviewed-by: Brian Foster <bfoster@redhat.com>

> -Dave.
>
> Diffstat:
>
> fs/xfs/xfs_inode.c | 408 ++++++++++++++++++++++++++++++++-----------------------
> fs/xfs/xfs_iops.c | 2 +-
> 2 files changed, 239 insertions(+), 171 deletions(-)
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs