From: Eric Sandeen <sandeen@sandeen.net>
To: Eric Sandeen <sandeen@redhat.com>, xfs-oss <xfs@oss.sgi.com>,
"F. Stoyan" <fstoyan@swapon.de>
Subject: [PATCH V2] xfs_db: disallow sb UUID write on v5 filesystems
Date: Tue, 07 Apr 2015 08:58:06 -0500 [thread overview]
Message-ID: <5523E26E.8010700@sandeen.net> (raw)
In-Reply-To: <5522A0DB.2010309@redhat.com>
Do not allow xfs_db (or the xfs_admin frontend) to change the UUID
of a V5 filesystem; this will cause UUID mismatches across the
filesystem, and we currently have no mechanism to update them all.
Changing only the superblock UUID makes all other metadata look
invalid, and xfs_repair reacts by junking everything.
Addresses-Debian-Bug: 782012
Reported-by: F. Stoyan <fstoyan@swapon.de>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
---
V2, fix up comment whitespace :/
(and add brian's review for dave's convenience)
diff --git a/db/sb.c b/db/sb.c
index 6cb665d..f31f4a2 100644
--- a/db/sb.c
+++ b/db/sb.c
@@ -363,6 +363,18 @@ uuid_f(
return 0;
}
+ /*
+ * For now, changing the UUID of V5 superblock filesystems is
+ * not supported; we do not have the infrastructure to fix all
+ * other metadata when a new superblock UUID is generated.
+ */
+ if (xfs_sb_version_hascrc(&mp->m_sb) &&
+ strcasecmp(argv[1], "rewrite")) {
+ dbprintf(_("%s: only 'rewrite' supported on V5 fs\n"),
+ progname);
+ return 0;
+ }
+
if (!strcasecmp(argv[1], "generate")) {
platform_uuid_generate(&uu);
} else if (!strcasecmp(argv[1], "nil")) {
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2015-04-07 13:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-06 15:06 [PATCH] xfs_db: disallow sb UUID write on v5 filesystems Eric Sandeen
2015-04-07 13:37 ` Brian Foster
2015-04-07 13:58 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5523E26E.8010700@sandeen.net \
--to=sandeen@sandeen.net \
--cc=fstoyan@swapon.de \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox