From: shhuiw <shhuiw@foxmail.com>
To: mszeredi@suse.cz, dchinner@redhat.com, david@fromorbit.com,
xfs@oss.sgi.com
Subject: [PATCH] xfstests/common/renameat2: pass the renameat2 flags from _rename_tests, to _rename_tests_source_dest
Date: Fri, 01 May 2015 16:00:19 +0800 [thread overview]
Message-ID: <55433293.7070301@foxmail.com> (raw)
_rename_tests() recognizes the 'flags' arg but doesn't pass it to
_rename_tests_source_dest() in old code, thus any 'flags' to
renameat2 is missed. Fix the missing.
Signed-off-by: Wang Sheng-Hui <shhuiw@foxmail.com>
---
common/renameat2 | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/common/renameat2 b/common/renameat2
index a335169..df2df2e 100644
--- a/common/renameat2
+++ b/common/renameat2
@@ -78,6 +78,7 @@ _rename_tests_source_dest()
local source=$1
local dest=$2
local options=$3
+ local flags=$4
for stype in none regu symb dire tree; do
for dtype in none regu symb dire tree; do
@@ -107,11 +108,11 @@ _rename_tests()
local flags=$2
#same directory renames
- _rename_tests_source_dest $testdir/src $testdir/dst "samedir "
+ _rename_tests_source_dest $testdir/src $testdir/dst "samedir
" $flags
#cross directory renames
mkdir $testdir/x $testdir/y
- _rename_tests_source_dest $testdir/x/src $testdir/y/dst "crossdir"
+ _rename_tests_source_dest $testdir/x/src $testdir/y/dst
"crossdir" $flags
rmdir $testdir/x $testdir/y
}
--
2.1.2
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2015-05-01 8:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 8:00 shhuiw [this message]
2015-05-01 8:07 ` [PATCH] xfstests/common/renameat2: pass the renameat2 flags from _rename_tests, to _rename_tests_source_dest shhuiw
-- strict thread matches above, loose matches on Subject: below --
2015-05-01 8:11 [PATCH] xfstests/common/renameat2: pass the renameat2 flags from _rename_tests " Wang Sheng-Hui
2015-05-15 0:51 ` Wang Sheng-Hui
2015-05-15 7:21 ` Eryu Guan
2015-05-15 7:18 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55433293.7070301@foxmail.com \
--to=shhuiw@foxmail.com \
--cc=david@fromorbit.com \
--cc=dchinner@redhat.com \
--cc=mszeredi@suse.cz \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox