* [PATCH] xfstests/common/renameat2: pass the renameat2 flags from _rename_tests, to _rename_tests_source_dest
@ 2015-05-01 8:00 shhuiw
2015-05-01 8:07 ` shhuiw
0 siblings, 1 reply; 6+ messages in thread
From: shhuiw @ 2015-05-01 8:00 UTC (permalink / raw)
To: mszeredi, dchinner, david, xfs
_rename_tests() recognizes the 'flags' arg but doesn't pass it to
_rename_tests_source_dest() in old code, thus any 'flags' to
renameat2 is missed. Fix the missing.
Signed-off-by: Wang Sheng-Hui <shhuiw@foxmail.com>
---
common/renameat2 | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/common/renameat2 b/common/renameat2
index a335169..df2df2e 100644
--- a/common/renameat2
+++ b/common/renameat2
@@ -78,6 +78,7 @@ _rename_tests_source_dest()
local source=$1
local dest=$2
local options=$3
+ local flags=$4
for stype in none regu symb dire tree; do
for dtype in none regu symb dire tree; do
@@ -107,11 +108,11 @@ _rename_tests()
local flags=$2
#same directory renames
- _rename_tests_source_dest $testdir/src $testdir/dst "samedir "
+ _rename_tests_source_dest $testdir/src $testdir/dst "samedir
" $flags
#cross directory renames
mkdir $testdir/x $testdir/y
- _rename_tests_source_dest $testdir/x/src $testdir/y/dst "crossdir"
+ _rename_tests_source_dest $testdir/x/src $testdir/y/dst
"crossdir" $flags
rmdir $testdir/x $testdir/y
}
--
2.1.2
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] xfstests/common/renameat2: pass the renameat2 flags from _rename_tests, to _rename_tests_source_dest
2015-05-01 8:00 [PATCH] xfstests/common/renameat2: pass the renameat2 flags from _rename_tests, to _rename_tests_source_dest shhuiw
@ 2015-05-01 8:07 ` shhuiw
0 siblings, 0 replies; 6+ messages in thread
From: shhuiw @ 2015-05-01 8:07 UTC (permalink / raw)
To: mszeredi, dchinner, david, xfs
On 05/01/2015 04:00 PM, shhuiw wrote:
>
> _rename_tests() recognizes the 'flags' arg but doesn't pass it to
> _rename_tests_source_dest() in old code, thus any 'flags' to
> renameat2 is missed. Fix the missing.
>
> Signed-off-by: Wang Sheng-Hui <shhuiw@foxmail.com>
> ---
> common/renameat2 | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/common/renameat2 b/common/renameat2
> index a335169..df2df2e 100644
> --- a/common/renameat2
> +++ b/common/renameat2
> @@ -78,6 +78,7 @@ _rename_tests_source_dest()
> local source=$1
> local dest=$2
> local options=$3
> + local flags=$4
>
> for stype in none regu symb dire tree; do
> for dtype in none regu symb dire tree; do
> @@ -107,11 +108,11 @@ _rename_tests()
> local flags=$2
>
> #same directory renames
> - _rename_tests_source_dest $testdir/src $testdir/dst "samedir "
> + _rename_tests_source_dest $testdir/src $testdir/dst "samedir
> " $flags
>
> #cross directory renames
> mkdir $testdir/x $testdir/y
> - _rename_tests_source_dest $testdir/x/src $testdir/y/dst "crossdir"
> + _rename_tests_source_dest $testdir/x/src $testdir/y/dst
> "crossdir" $flags
> rmdir $testdir/x $testdir/y
> }
>
Sorry, this patch seems get corrupted by my mail client.
Will resend it.
Regards,
Sheng-Hui
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] xfstests/common/renameat2: pass the renameat2 flags from _rename_tests to _rename_tests_source_dest
@ 2015-05-01 8:11 Wang Sheng-Hui
2015-05-15 0:51 ` Wang Sheng-Hui
2015-05-15 7:18 ` Eryu Guan
0 siblings, 2 replies; 6+ messages in thread
From: Wang Sheng-Hui @ 2015-05-01 8:11 UTC (permalink / raw)
To: mszeredi, david, xfs
_rename_tests() records the 'flags' arg but doesn't pass it to
_rename_tests_source_dest() in old code, thus any 'flags' to
renameat2 is missed. Fix the missing.
Signed-off-by: Wang Sheng-Hui <shhuiw@foxmail.com>
---
common/renameat2 | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/common/renameat2 b/common/renameat2
index a335169..df2df2e 100644
--- a/common/renameat2
+++ b/common/renameat2
@@ -78,6 +78,7 @@ _rename_tests_source_dest()
local source=$1
local dest=$2
local options=$3
+ local flags=$4
for stype in none regu symb dire tree; do
for dtype in none regu symb dire tree; do
@@ -107,11 +108,11 @@ _rename_tests()
local flags=$2
#same directory renames
- _rename_tests_source_dest $testdir/src $testdir/dst "samedir "
+ _rename_tests_source_dest $testdir/src $testdir/dst "samedir " $flags
#cross directory renames
mkdir $testdir/x $testdir/y
- _rename_tests_source_dest $testdir/x/src $testdir/y/dst "crossdir"
+ _rename_tests_source_dest $testdir/x/src $testdir/y/dst "crossdir" $flags
rmdir $testdir/x $testdir/y
}
--
2.1.2
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] xfstests/common/renameat2: pass the renameat2 flags from _rename_tests to _rename_tests_source_dest
2015-05-01 8:11 [PATCH] xfstests/common/renameat2: pass the renameat2 flags from _rename_tests " Wang Sheng-Hui
@ 2015-05-15 0:51 ` Wang Sheng-Hui
2015-05-15 7:21 ` Eryu Guan
2015-05-15 7:18 ` Eryu Guan
1 sibling, 1 reply; 6+ messages in thread
From: Wang Sheng-Hui @ 2015-05-15 0:51 UTC (permalink / raw)
To: mszeredi, david, xfs, Eryu Guan, Dave Chinner
On 2015年05月01日 16:11, Wang Sheng-Hui wrote:
> _rename_tests() records the 'flags' arg but doesn't pass it to
> _rename_tests_source_dest() in old code, thus any 'flags' to
> renameat2 is missed. Fix the missing.
>
> Signed-off-by: Wang Sheng-Hui <shhuiw@foxmail.com>
> ---
> common/renameat2 | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/common/renameat2 b/common/renameat2
> index a335169..df2df2e 100644
> --- a/common/renameat2
> +++ b/common/renameat2
> @@ -78,6 +78,7 @@ _rename_tests_source_dest()
> local source=$1
> local dest=$2
> local options=$3
> + local flags=$4
>
> for stype in none regu symb dire tree; do
> for dtype in none regu symb dire tree; do
> @@ -107,11 +108,11 @@ _rename_tests()
> local flags=$2
>
> #same directory renames
> - _rename_tests_source_dest $testdir/src $testdir/dst "samedir "
> + _rename_tests_source_dest $testdir/src $testdir/dst "samedir " $flags
>
> #cross directory renames
> mkdir $testdir/x $testdir/y
> - _rename_tests_source_dest $testdir/x/src $testdir/y/dst "crossdir"
> + _rename_tests_source_dest $testdir/x/src $testdir/y/dst "crossdir" $flags
> rmdir $testdir/x $testdir/y
> }
>
>
Any comments?
Regards,
Sheng-Hui
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfstests/common/renameat2: pass the renameat2 flags from _rename_tests to _rename_tests_source_dest
2015-05-15 0:51 ` Wang Sheng-Hui
@ 2015-05-15 7:21 ` Eryu Guan
0 siblings, 0 replies; 6+ messages in thread
From: Eryu Guan @ 2015-05-15 7:21 UTC (permalink / raw)
To: Wang Sheng-Hui; +Cc: xfs
On Fri, May 15, 2015 at 08:51:29AM +0800, Wang Sheng-Hui wrote:
>
>
> On 2015年05月01日 16:11, Wang Sheng-Hui wrote:
> > _rename_tests() records the 'flags' arg but doesn't pass it to
> > _rename_tests_source_dest() in old code, thus any 'flags' to
> > renameat2 is missed. Fix the missing.
> >
> > Signed-off-by: Wang Sheng-Hui <shhuiw@foxmail.com>
> > ---
> > common/renameat2 | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/common/renameat2 b/common/renameat2
> > index a335169..df2df2e 100644
> > --- a/common/renameat2
> > +++ b/common/renameat2
> > @@ -78,6 +78,7 @@ _rename_tests_source_dest()
> > local source=$1
> > local dest=$2
> > local options=$3
> > + local flags=$4
> >
> > for stype in none regu symb dire tree; do
> > for dtype in none regu symb dire tree; do
> > @@ -107,11 +108,11 @@ _rename_tests()
> > local flags=$2
> >
> > #same directory renames
> > - _rename_tests_source_dest $testdir/src $testdir/dst "samedir "
> > + _rename_tests_source_dest $testdir/src $testdir/dst "samedir " $flags
> >
> > #cross directory renames
> > mkdir $testdir/x $testdir/y
> > - _rename_tests_source_dest $testdir/x/src $testdir/y/dst "crossdir"
> > + _rename_tests_source_dest $testdir/x/src $testdir/y/dst "crossdir" $flags
> > rmdir $testdir/x $testdir/y
> > }
> >
> >
>
> Any comments?
You can send xfstests patch to fstests@vger.kernel.org next time.
Thanks,
Eryu
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xfstests/common/renameat2: pass the renameat2 flags from _rename_tests to _rename_tests_source_dest
2015-05-01 8:11 [PATCH] xfstests/common/renameat2: pass the renameat2 flags from _rename_tests " Wang Sheng-Hui
2015-05-15 0:51 ` Wang Sheng-Hui
@ 2015-05-15 7:18 ` Eryu Guan
1 sibling, 0 replies; 6+ messages in thread
From: Eryu Guan @ 2015-05-15 7:18 UTC (permalink / raw)
To: Wang Sheng-Hui; +Cc: mszeredi, xfs
On Fri, May 01, 2015 at 04:11:07PM +0800, Wang Sheng-Hui wrote:
> _rename_tests() records the 'flags' arg but doesn't pass it to
> _rename_tests_source_dest() in old code, thus any 'flags' to
> renameat2 is missed. Fix the missing.
>
> Signed-off-by: Wang Sheng-Hui <shhuiw@foxmail.com>
Looks good to me.
Reviewed-by: Eryu Guan <eguan@redhat.com>
> ---
> common/renameat2 | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/common/renameat2 b/common/renameat2
> index a335169..df2df2e 100644
> --- a/common/renameat2
> +++ b/common/renameat2
> @@ -78,6 +78,7 @@ _rename_tests_source_dest()
> local source=$1
> local dest=$2
> local options=$3
> + local flags=$4
>
> for stype in none regu symb dire tree; do
> for dtype in none regu symb dire tree; do
> @@ -107,11 +108,11 @@ _rename_tests()
> local flags=$2
>
> #same directory renames
> - _rename_tests_source_dest $testdir/src $testdir/dst "samedir "
> + _rename_tests_source_dest $testdir/src $testdir/dst "samedir " $flags
>
> #cross directory renames
> mkdir $testdir/x $testdir/y
> - _rename_tests_source_dest $testdir/x/src $testdir/y/dst "crossdir"
> + _rename_tests_source_dest $testdir/x/src $testdir/y/dst "crossdir" $flags
> rmdir $testdir/x $testdir/y
> }
>
> --
> 2.1.2
>
>
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-05-15 7:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-01 8:00 [PATCH] xfstests/common/renameat2: pass the renameat2 flags from _rename_tests, to _rename_tests_source_dest shhuiw
2015-05-01 8:07 ` shhuiw
-- strict thread matches above, loose matches on Subject: below --
2015-05-01 8:11 [PATCH] xfstests/common/renameat2: pass the renameat2 flags from _rename_tests " Wang Sheng-Hui
2015-05-15 0:51 ` Wang Sheng-Hui
2015-05-15 7:21 ` Eryu Guan
2015-05-15 7:18 ` Eryu Guan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox