From: Eric Sandeen <sandeen@sandeen.net>
To: "Darrick J. Wong" <darrick.wong@oracle.com>, david@fromorbit.com
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 4/5] xfs_db: enable blockget for v5 filesystems
Date: Tue, 26 May 2015 18:07:32 -0500 [thread overview]
Message-ID: <5564FCB4.6070603@sandeen.net> (raw)
In-Reply-To: <20150526225153.26434.96347.stgit@birch.djwong.org>
On 5/26/15 5:51 PM, Darrick J. Wong wrote:
> Plumb in the necessary magic number checks and other fixups required
> to handle v5 filesystems.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> @@ -799,8 +803,6 @@ blockget_f(
> * filters out, or we need to actually do the work to make check support
> * crc enabled filesystems.
> */
> - if (xfs_sb_version_hascrc(&mp->m_sb))
> - return 0;
Hm, the comment above these lines says:
/*
* XXX: check does not support CRC enabled filesystems. Return
* immediately, silently, with success but without doing anything here
* initially so that xfstests can run without modification on metadata
* enabled filesystems.
*
* XXX: ultimately we need to dump an error message here that xfstests
* filters out, or we need to actually do the work to make check support
* crc enabled filesystems.
*/
but now we don't. So I guess the comment should go too?
I guess check is deprecated now, so the comment is stale anyway...
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-05-26 23:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 22:51 [PATCH 0/5] xfsprogs May 2015 patchbomb Darrick J. Wong
2015-05-26 22:51 ` [PATCH 1/5] xfs_repair: refuse to run if we don't recognize version or feature flags Darrick J. Wong
2015-05-26 23:49 ` Eric Sandeen
2015-05-27 5:45 ` [PATCH v2 " Darrick J. Wong
2015-05-27 14:54 ` Eric Sandeen
2015-05-27 15:16 ` Eric Sandeen
2015-05-27 15:27 ` Eric Sandeen
2015-05-27 16:04 ` Fanael Linithien
2015-05-27 16:26 ` Eric Sandeen
2015-05-27 17:17 ` Darrick J. Wong
2015-05-27 15:19 ` Fanael Linithien
2015-05-27 16:42 ` Darrick J. Wong
2015-05-27 18:15 ` [PATCH v3 " Darrick J. Wong
2015-05-27 18:42 ` Fanael Linithien
2015-05-26 22:51 ` [PATCH 2/5] xfs_repair: better checking of v5 metadata fields Darrick J. Wong
2015-05-26 23:58 ` Dave Chinner
2015-05-27 5:44 ` [PATCH v2 " Darrick J. Wong
2015-05-31 21:32 ` Dave Chinner
2015-05-26 22:51 ` [PATCH 3/5] xfs_repair: ensure .. is set to a sane ino value when rebuilding dir Darrick J. Wong
2015-05-26 22:51 ` [PATCH 4/5] xfs_db: enable blockget for v5 filesystems Darrick J. Wong
2015-05-26 23:07 ` Eric Sandeen [this message]
2015-05-26 23:13 ` Darrick J. Wong
2015-05-26 23:14 ` [PATCH v2 " Darrick J. Wong
2015-05-26 22:51 ` [PATCH 5/5] xfs_db: enable blocktrash for checksummed filesystems Darrick J. Wong
2015-05-28 5:08 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5564FCB4.6070603@sandeen.net \
--to=sandeen@sandeen.net \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox