From: Eric Sandeen <sandeen@sandeen.net>
To: "Darrick J. Wong" <darrick.wong@oracle.com>, david@fromorbit.com
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v2 1/5] xfs_repair: refuse to run if we don't recognize version or feature flags
Date: Wed, 27 May 2015 10:16:59 -0500 [thread overview]
Message-ID: <5565DFEB.9040000@sandeen.net> (raw)
In-Reply-To: <5565DAA7.4040406@sandeen.net>
On 5/27/15 9:54 AM, Eric Sandeen wrote:
> On 5/27/15 12:45 AM, Darrick J. Wong wrote:
>> Apparently xfs_repair running on a v5 filesystem doesn't check the
>> compat, rocompat, or incompat feature flags for bits that it doesn't
>> know about, which means that old xfs_repairs can wreak havoc. So,
>> strengthen the checks to prevent repair from "repairing" anything it
>> doesn't understand.
>>
>> v2: Move the complaint code after the version number check, and print
>> the actual feature bits that we don't recognize.
>
> Thanks. That's a bit more wordy, but probably better, in the end.
>
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Whoops, retract that, thanks for spotting those C&P errors, Fanael!
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-05-27 15:17 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 22:51 [PATCH 0/5] xfsprogs May 2015 patchbomb Darrick J. Wong
2015-05-26 22:51 ` [PATCH 1/5] xfs_repair: refuse to run if we don't recognize version or feature flags Darrick J. Wong
2015-05-26 23:49 ` Eric Sandeen
2015-05-27 5:45 ` [PATCH v2 " Darrick J. Wong
2015-05-27 14:54 ` Eric Sandeen
2015-05-27 15:16 ` Eric Sandeen [this message]
2015-05-27 15:27 ` Eric Sandeen
2015-05-27 16:04 ` Fanael Linithien
2015-05-27 16:26 ` Eric Sandeen
2015-05-27 17:17 ` Darrick J. Wong
2015-05-27 15:19 ` Fanael Linithien
2015-05-27 16:42 ` Darrick J. Wong
2015-05-27 18:15 ` [PATCH v3 " Darrick J. Wong
2015-05-27 18:42 ` Fanael Linithien
2015-05-26 22:51 ` [PATCH 2/5] xfs_repair: better checking of v5 metadata fields Darrick J. Wong
2015-05-26 23:58 ` Dave Chinner
2015-05-27 5:44 ` [PATCH v2 " Darrick J. Wong
2015-05-31 21:32 ` Dave Chinner
2015-05-26 22:51 ` [PATCH 3/5] xfs_repair: ensure .. is set to a sane ino value when rebuilding dir Darrick J. Wong
2015-05-26 22:51 ` [PATCH 4/5] xfs_db: enable blockget for v5 filesystems Darrick J. Wong
2015-05-26 23:07 ` Eric Sandeen
2015-05-26 23:13 ` Darrick J. Wong
2015-05-26 23:14 ` [PATCH v2 " Darrick J. Wong
2015-05-26 22:51 ` [PATCH 5/5] xfs_db: enable blocktrash for checksummed filesystems Darrick J. Wong
2015-05-28 5:08 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5565DFEB.9040000@sandeen.net \
--to=sandeen@sandeen.net \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox