From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id A2C147F4E for ; Thu, 28 May 2015 19:05:39 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay3.corp.sgi.com (Postfix) with ESMTP id 1D713AC001 for ; Thu, 28 May 2015 17:05:35 -0700 (PDT) Received: from smtpbgbr1.qq.com (smtpbgbr1.qq.com [54.207.19.206]) by cuda.sgi.com with ESMTP id DR5oDLT8oYBSKqZR (version=TLSv1 cipher=AES256-SHA bits=256 verify=NO) for ; Thu, 28 May 2015 17:05:31 -0700 (PDT) Message-ID: <5567AD2F.4000103@foxmail.com> Date: Fri, 29 May 2015 08:05:03 +0800 From: Wang Sheng-Hui MIME-Version: 1.0 Subject: Re: [PATCH] xfsprogs: merge the duplicated condition in xfs_mkfs.c/validate_ag_geometry References: <1432796808-862-1-git-send-email-shhuiw@foxmail.com> <55672C4C.2010805@sandeen.net> In-Reply-To: <55672C4C.2010805@sandeen.net> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Eric Sandeen , xfs@oss.sgi.com, dchinner@redhat.com, david@fromorbit.com, bfoster@redhat.com CgpPbiAyMDE15bm0MDXmnIgyOOaXpSAyMjo1NSwgRXJpYyBTYW5kZWVuIHdyb3RlOgo+IE9uIDUv MjgvMTUgMjowNiBBTSwgV2FuZyBTaGVuZy1IdWkgd3JvdGU6Cj4+IFNvbWUgY29uZGl0aW9ucyBh cmUgZHVwbGljYXRlZC4gTWVyZ2UgdGhlbS4KPiAKPiBXaGlsZSB5b3UgYXJlIGNvcnJlY3QgdGhh dCB0aGV5IGFyZSBkdXBsaWNhdGVkLCBzaW1wbHkgY29tYmluaW5nCj4gdGhlbSBkb2Vzbid0IG1r YWUgYSBsb3Qgb2Ygc2Vuc2U7IG5vdyB3ZSdsbCBnZXQgdGhpcyBzb3J0IG9mCj4gZXJyb3IgbWVz c2FnZToKPiAKPj4gYWdzaXplICglbGxkIGJsb2NrcykgdG9vIHNtYWxsLCBuZWVkIGF0IGxlYXN0 ICVsbGQgYmxvY2tzCj4+IHRvbyBtYW55IGFsbG9jYXRpb24gZ3JvdXBzIGZvciBzaXplID0gJWxs ZAo+PiBuZWVkIGF0IG1vc3QgJWxsZCBhbGxvY2F0aW9uIGdyb3Vwcwo+IAo+IGFuZCB3aGF0IHNo b3VsZCBhIHVzZXIgZG8gd2l0aCB0aGF0IGluZm9ybWF0aW9uPyAgSXQncyBzb21ld2hhdAo+IG5v bnNlbnNpY2FsLgo+IAo+IFRoZSBjb2RlIGFzIGl0IGlzIHRvZGF5LCBhbmQgYXMgaXQgaGFzIGJl ZW4gc2luY2UgY29tbWl0Cj4gMWYxYjhiZTc5MjY0ODAwNDZlYWQ3Yjk4Yzk4NTBhY2U3YmNkODJh MywgZG9lc24ndCBtYWtlIG11Y2ggc2Vuc2UsCj4gYmVjYXVzZSB3ZSBjYW4gbmV2ZXIgaGl0IHRo ZSBzZWNvbmQgY29uZGl0aW9uYWwuICBCdXQgc2ltcGx5Cj4gY29tYmluaW5nIHRoZW0gZG9lc24n dCBsb29rIGxpa2UgdGhlIHJpZ2h0IGFuc3dlciB0byBtZS4KPiAKPiBJZiB5b3UgbG9vayBhdCB0 aGUgYWJvdmUgY29tbWl0LCB3aGF0IGl0IHVzZWQgdG8gZG8gd2FzIHNvbWV0aGluZwo+IGxpa2U6 Cj4gCj4gLSAgICAgICAgICAgICAgIC8qCj4gLSAgICAgICAgICAgICAgICAqIElmIHRoZSBzcGVj aWZpZWQgYWdzaXplIGlzIHRvbyBzbWFsbCwgb3IgdG9vIGxhcmdlLAo+IC0gICAgICAgICAgICAg ICAgKiBjb21wbGFpbi4KPiAtICAgICAgICAgICAgICAgICovCj4gLSAgICAgICAgICAgICAgIGlm IChhZ3NpemUgPCBYRlNfQUdfTUlOX0JMT0NLUyhibG9ja2xvZykpIHsKPiAtICAgICAgICAgICAg ICAgICAgICAgICBmcHJpbnRmKHN0ZGVyciwKPiAtICAgICAgICAgICAgICAgXygiYWdzaXplICgl bGxkYikgdG9vIHNtYWxsLCBuZWVkIGF0IGxlYXN0ICVsbGQgYmxvY2tzXG4iKSwKPiAtICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIChsb25nIGxvbmcpYWdzaXplLAo+IC0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgKGxvbmcgbG9uZylYRlNfQUdfTUlOX0JMT0NLUyhibG9ja2xv ZykpOwo+IC0gICAgICAgICAgICAgICAgICAgICAgIHVzYWdlKCk7Cj4gLSAgICAgICAgICAgICAg IH0KPiAKPiA8c25pcD4KPiAKPiAtICAgICAgIC8qCj4gLSAgICAgICAgKiBJZiB0aGUgYWcgc2l6 ZSBpcyB0b28gc21hbGwsIGNvbXBsYWluIGlmIGFnY291bnQvYWdzaXplIHdhcwo+IC0gICAgICAg ICogc3BlY2lmaWVkLCBhbmQgZml4IGl0IG90aGVyd2lzZS4KPiAtICAgICAgICAqLwo+IC0gICAg ICAgaWYgKGFnc2l6ZSA8IFhGU19BR19NSU5fQkxPQ0tTKGJsb2NrbG9nKSkgewo+IC0gICAgICAg ICAgICAgICBpZiAoZGFmbGFnIHx8IGRhc2l6ZSkgewo+IC0gICAgICAgICAgICAgICAgICAgICAg IGZwcmludGYoc3RkZXJyLAo+IC0gICAgICAgICAgICAgICAgICAgICAgIF8oInRvbyBtYW55IGFs bG9jYXRpb24gZ3JvdXBzIGZvciBzaXplID0gJWxsZFxuIiksCj4gLSAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAobG9uZyBsb25nKWFnc2l6ZSk7Cj4gLSAgICAgICAgICAgICAgICAgICAg ICAgZnByaW50ZihzdGRlcnIsCj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBfKCJu ZWVkIGF0IG1vc3QgJWxsZCBhbGxvY2F0aW9uIGdyb3Vwc1xuIiksCj4gLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAobG9uZyBsb25nKQo+IC0gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgKGRibG9ja3MgLyBYRlNfQUdfTUlOX0JMT0NLUyhibG9ja2xvZykgKwo+IC0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgKGRibG9ja3MgJSBYRlNfQUdfTUlOX0JMT0NLUyhibG9j a2xvZykgIT0gMCkpKTsKPiAKPiAuLi4KPiAKPiBJICp0aGluayogdGhlIGludGVudCB3YXMgdG8g dXNlIGRpZmZlcmVudCBtZXNzYWdlcyBiYXNlZCBvbiB3aGF0Cj4gd2FzIHNwZWNpZmllZCBieSB0 aGUgdXNlcjsgaS5lLiBpZiBhZ3NpemUgd2FzIHNwZWNpZmllZCwgYW5kIGlzIHRvbwo+IHNtYWxs LCB0aGVuIHNheToKPiAKPj4gYWdzaXplICglbGxkIGJsb2NrcykgdG9vIHNtYWxsLCBuZWVkIGF0 IGxlYXN0ICVsbGQgYmxvY2tzCj4gCj4gYnV0IGlmIGFnY291bnQgd2FzIHNwZWNpZmllZCwgYW5k IHdhcyB0b28gbGFyZ2UsIHRoZW4gc2F5Ogo+IAo+PiB0b28gbWFueSBhbGxvY2F0aW9uIGdyb3Vw cyBmb3Igc2l6ZSA9ICVsbGQKPj4gbmVlZCBhdCBtb3N0ICVsbGQgYWxsb2NhdGlvbiBncm91cHMK PiAKPiBidXQgY29tYmluaW5nIHRob3NlIHR3byBtZXNzYWdlcyBkb2Vzbid0IG1ha2Ugc2Vuc2Ug dG8gbWUuCj4gCgpHb3QgaXQsIEVyaWMuCgpSZWdhcmRzLApTaGVuZy1IdWkKCj4gLUVyaWMKPiAK PiAKPj4gU2lnbmVkLW9mZi1ieTogV2FuZyBTaGVuZy1IdWkgPHNoaHVpd0Bmb3htYWlsLmNvbT4K Pj4gLS0tCj4+ICBta2ZzL3hmc19ta2ZzLmMgfCAyNCArKysrKysrKy0tLS0tLS0tLS0tLS0tLS0K Pj4gIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDE2IGRlbGV0aW9ucygtKQo+Pgo+ PiBkaWZmIC0tZ2l0IGEvbWtmcy94ZnNfbWtmcy5jIGIvbWtmcy94ZnNfbWtmcy5jCj4+IGluZGV4 IGUyYTA1MmQuLjdlYzI1NTYgMTAwNjQ0Cj4+IC0tLSBhL21rZnMveGZzX21rZnMuYwo+PiArKysg Yi9ta2ZzL3hmc19ta2ZzLmMKPj4gQEAgLTc0MCwyMiArNzQwLDYgQEAgdmFsaWRhdGVfYWdfZ2Vv bWV0cnkoCj4+ICAJX191aW50NjRfdAlhZ3NpemUsCj4+ICAJX191aW50NjRfdAlhZ2NvdW50KQo+ PiAgewo+PiAtCWlmIChhZ3NpemUgPCBYRlNfQUdfTUlOX0JMT0NLUyhibG9ja2xvZykpIHsKPj4g LQkJZnByaW50ZihzdGRlcnIsCj4+IC0JXygiYWdzaXplICglbGxkIGJsb2NrcykgdG9vIHNtYWxs LCBuZWVkIGF0IGxlYXN0ICVsbGQgYmxvY2tzXG4iKSwKPj4gLQkJCShsb25nIGxvbmcpYWdzaXpl LAo+PiAtCQkJKGxvbmcgbG9uZylYRlNfQUdfTUlOX0JMT0NLUyhibG9ja2xvZykpOwo+PiAtCQl1 c2FnZSgpOwo+PiAtCX0KPj4gLQo+PiAtCWlmIChhZ3NpemUgPiBYRlNfQUdfTUFYX0JMT0NLUyhi bG9ja2xvZykpIHsKPj4gLQkJZnByaW50ZihzdGRlcnIsCj4+IC0JXygiYWdzaXplICglbGxkIGJs b2NrcykgdG9vIGJpZywgbWF4aW11bSBpcyAlbGxkIGJsb2Nrc1xuIiksCj4+IC0JCQkobG9uZyBs b25nKWFnc2l6ZSwKPj4gLQkJCShsb25nIGxvbmcpWEZTX0FHX01BWF9CTE9DS1MoYmxvY2tsb2cp KTsKPj4gLQkJdXNhZ2UoKTsKPj4gLQl9Cj4+IC0KPj4gIAlpZiAoYWdzaXplID4gZGJsb2Nrcykg ewo+PiAgCQlmcHJpbnRmKHN0ZGVyciwKPj4gIAlfKCJhZ3NpemUgKCVsbGQgYmxvY2tzKSB0b28g YmlnLCBkYXRhIGFyZWEgaXMgJWxsZCBibG9ja3NcbiIpLAo+PiBAQCAtNzY1LDYgKzc0OSwxMCBA QCB2YWxpZGF0ZV9hZ19nZW9tZXRyeSgKPj4gIAo+PiAgCWlmIChhZ3NpemUgPCBYRlNfQUdfTUlO X0JMT0NLUyhibG9ja2xvZykpIHsKPj4gIAkJZnByaW50ZihzdGRlcnIsCj4+ICsJXygiYWdzaXpl ICglbGxkIGJsb2NrcykgdG9vIHNtYWxsLCBuZWVkIGF0IGxlYXN0ICVsbGQgYmxvY2tzXG4iKSwK Pj4gKwkJCShsb25nIGxvbmcpYWdzaXplLAo+PiArCQkJKGxvbmcgbG9uZylYRlNfQUdfTUlOX0JM T0NLUyhibG9ja2xvZykpOwo+PiArCQlmcHJpbnRmKHN0ZGVyciwKPj4gIAlfKCJ0b28gbWFueSBh bGxvY2F0aW9uIGdyb3VwcyBmb3Igc2l6ZSA9ICVsbGRcbiIpLAo+PiAgCQkJCShsb25nIGxvbmcp YWdzaXplKTsKPj4gIAkJZnByaW50ZihzdGRlcnIsIF8oIm5lZWQgYXQgbW9zdCAlbGxkIGFsbG9j YXRpb24gZ3JvdXBzXG4iKSwKPj4gQEAgLTc3NSw2ICs3NjMsMTAgQEAgdmFsaWRhdGVfYWdfZ2Vv bWV0cnkoCj4+ICAKPj4gIAlpZiAoYWdzaXplID4gWEZTX0FHX01BWF9CTE9DS1MoYmxvY2tsb2cp KSB7Cj4+ICAJCWZwcmludGYoc3RkZXJyLAo+PiArCV8oImFnc2l6ZSAoJWxsZCBibG9ja3MpIHRv byBiaWcsIG1heGltdW0gaXMgJWxsZCBibG9ja3NcbiIpLAo+PiArCQkJKGxvbmcgbG9uZylhZ3Np emUsCj4+ICsJCQkobG9uZyBsb25nKVhGU19BR19NQVhfQkxPQ0tTKGJsb2NrbG9nKSk7Cj4+ICsJ CWZwcmludGYoc3RkZXJyLAo+PiAgCV8oInRvbyBmZXcgYWxsb2NhdGlvbiBncm91cHMgZm9yIHNp emUgPSAlbGxkXG4iKSwgKGxvbmcgbG9uZylhZ3NpemUpOwo+PiAgCQlmcHJpbnRmKHN0ZGVyciwK Pj4gIAlfKCJuZWVkIGF0IGxlYXN0ICVsbGQgYWxsb2NhdGlvbiBncm91cHNcbiIpLAo+Pgo+IAo+ IAo+IAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCnhm cyBtYWlsaW5nIGxpc3QKeGZzQG9zcy5zZ2kuY29tCmh0dHA6Ly9vc3Muc2dpLmNvbS9tYWlsbWFu L2xpc3RpbmZvL3hmcwo=