From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 170D37F60 for ; Mon, 8 Jun 2015 08:04:44 -0500 (CDT) Message-ID: <557592E7.2010805@sgi.com> Date: Mon, 08 Jun 2015 08:04:39 -0500 From: Mark Tinguely MIME-Version: 1.0 Subject: Re: [PATCH] xfs: fix in the setting of logbsize References: <1433510925-11438-1-git-send-email-alnovak@suse.cz> <20150605222257.GY24666@dastard> In-Reply-To: List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Ales Novak Cc: xfs@oss.sgi.com On 06/07/15 04:16, Ales Novak wrote: > > On 2015-6-6 00:22, Dave Chinner wrote: > >> Can you give more information about the crashes? From this >> description, I do not know whether this is a work around or a fix >> because I don't know what code is actually causing the problem or >> the circumstances in which the crash occurs. Hence I cannot >> determine if your change is the right change to make or whether the >> documetnation is simply wrong and we have a real bug we shoul dbe >> fixing. > > The crashes occurred with logsunit=192k and logbsize=256k. xlog_sync() > is calculating in logsunit units: > > count = XLOG_LSUNITTOB(log, XLOG_BTOLSUNIT(log, count_init)); > > With count_init=256k, the calculated roundoff will try to cover that in > two 192k units. This roundoff is passed to the xlog_pack_data() which > walks the buffer and (hopefully) fails when it hits its 256k border. > Talked about this once before: http://oss.sgi.com/archives/xfs/2013-03/msg00039.html Mark. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs