From: Eric Sandeen <sandeen@redhat.com>
To: Christoph Hellwig <hch@infradead.org>, Jan Tulak <jtulak@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] mkfs.xfs: always use underlying fs sector size when mkfs'ing a file
Date: Fri, 19 Jun 2015 10:17:10 -0500 [thread overview]
Message-ID: <55843276.5020804@redhat.com> (raw)
In-Reply-To: <20150619150904.GB22842@infradead.org>
On 6/19/15 10:09 AM, Christoph Hellwig wrote:
> On Thu, Jun 18, 2015 at 07:03:39AM -0400, Jan Tulak wrote:
>> This changes get_topology only for ENABLE_BLKID branch of #ifdef. Is that intentional, i.e. we don't expect anyone not using ENABLE_BLKID? Because otherwise, if mkfs is compiled without ENABLE_BLKID, then all we get is:
>
> I'm in favor of killing the !ENABLE_BLKID entirely. The proper
> support in blkid has been around long enough to require it.
>
though we also claim to nominally support building on osx, irix, etc, which doesn't have that library, right?
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-06-19 15:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 23:26 [PATCH] mkfs.xfs: always use underlying fs sector size when mkfs'ing a file Eric Sandeen
2015-06-18 11:03 ` Jan Tulak
2015-06-18 14:57 ` Eric Sandeen
2015-06-19 7:01 ` Jan Tulak
2015-06-19 15:09 ` Christoph Hellwig
2015-06-19 15:17 ` Eric Sandeen [this message]
2015-06-19 15:21 ` Christoph Hellwig
2015-06-19 15:24 ` Eric Sandeen
2015-06-19 17:09 ` PATCH V2] " Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55843276.5020804@redhat.com \
--to=sandeen@redhat.com \
--cc=hch@infradead.org \
--cc=jtulak@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox