From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>, Eric Sandeen <sandeen@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs_metadump: obfuscate remote symlinks on CRC filesystems
Date: Sun, 21 Jun 2015 20:54:14 -0500 [thread overview]
Message-ID: <55876AC6.2080407@sandeen.net> (raw)
In-Reply-To: <20150621091419.GA26833@infradead.org>
On 6/21/15 4:14 AM, Christoph Hellwig wrote:
> On Fri, Jun 19, 2015 at 03:30:32PM -0500, Eric Sandeen wrote:
>> On CRC filesystems, the symlink block starts with a header,
>> which contains magic, "XLSM"
>>
>> The code happens to "work" today w/o corrupting anything,
>> because it seems "XSLM" as a string, decides it's too short
>> to obfuscate, and leaves it alone.
>>
>> But the real symlink target is untouched. Fix that by moving
>> the pointer to the string we want to obfuscate by the size
>> of the header, and shorten the length to obfuscate accordingly.
>
> Looks good,
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> Any chance to get a test for this into xfstests?
I have a larger metadump testcase brewing, it'd cover this too.
Thanks,
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2015-06-22 1:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-19 20:30 [PATCH] xfs_metadump: obfuscate remote symlinks on CRC filesystems Eric Sandeen
2015-06-21 9:14 ` Christoph Hellwig
2015-06-22 1:54 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55876AC6.2080407@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox