From: Eric Sandeen <sandeen@sandeen.net>
To: Dave Chinner <david@fromorbit.com>, xfs@oss.sgi.com
Subject: Re: [PATCH 3/4] xfs: log recovery needs to validate against sb_meta_uuid
Date: Mon, 03 Aug 2015 14:42:58 -0700 [thread overview]
Message-ID: <55BFE062.8020704@sandeen.net> (raw)
In-Reply-To: <55BF99AD.2090103@sandeen.net>
On 8/3/15 9:41 AM, Eric Sandeen wrote:
> On 8/3/15 12:40 AM, Dave Chinner wrote:
>> From: Dave Chinner <dchinner@redhat.com>
>>
>> Now that sb_uuid can be changed by the user, we cannot use this to
>> validate the metadata blocks being recovered belong to this
>> filesystem. We must check against the sb_meta_uuid as that will
>> remain unchanged.
>>
>> There is a complication in this code - the superblock itself. We can
>> not check the sb_meta_uuid unconditionally, as that may not be set
>> on disk. Hence we must verify the superblock sb_uuid matches between
>> the log record and the in-core superblock.
>>
>> Found by inspection after the previous two problems were found.
>
> So, I also had this in my older patchset, I think it's needed for
> proper log recovery as well. I'm not sure why I didn't hit the
> xlog_recover_get_buf_lsn problem, though:
Oh god, all this is is a difference in unlikely's upstream. Kill me now!
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-08-03 21:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 7:40 [PATCH 0/4] xfs: sb_meta_uuid fixes Dave Chinner
2015-08-03 7:40 ` [PATCH 1/4] xfs: fix sb_meta_uuid usage Dave Chinner
2015-08-03 16:12 ` Eric Sandeen
2015-08-03 16:27 ` Eric Sandeen
2015-08-03 7:40 ` [PATCH 2/4] xfs: growfs not aware of sb_meta_uuid Dave Chinner
2015-08-03 16:18 ` Eric Sandeen
2015-08-03 7:40 ` [PATCH 3/4] xfs: log recovery needs to validate against sb_meta_uuid Dave Chinner
2015-08-03 16:41 ` Eric Sandeen
2015-08-03 21:42 ` Eric Sandeen [this message]
2015-08-03 7:40 ` [PATCH 4/4] xfs: dquots should be stamped with sb_meta_uuid Dave Chinner
2015-08-03 16:23 ` Eric Sandeen
2015-08-03 16:26 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BFE062.8020704@sandeen.net \
--to=sandeen@sandeen.net \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox