From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id BCDB37FAE for ; Tue, 4 Aug 2015 11:24:39 -0500 (CDT) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay3.corp.sgi.com (Postfix) with ESMTP id 4E635AC004 for ; Tue, 4 Aug 2015 09:24:35 -0700 (PDT) Received: from sandeen.net (sandeen.net [63.231.237.45]) by cuda.sgi.com with ESMTP id z0vD9gspfQsK19kO for ; Tue, 04 Aug 2015 09:24:34 -0700 (PDT) Message-ID: <55C0E73B.1000904@sandeen.net> Date: Tue, 04 Aug 2015 09:24:27 -0700 From: Eric Sandeen MIME-Version: 1.0 Subject: Re: [PATCH v3] xfsprogs: blkid is now mandatory References: <1156743222.24471614.1436281858017.JavaMail.zimbra@redhat.com> <1436346893-11831-1-git-send-email-jtulak@redhat.com> <1508777144.956841.1437482376774.JavaMail.zimbra@redhat.com> <20150726162530.GE29329@infradead.org> <1326157887.2004059.1438598404429.JavaMail.zimbra@redhat.com> <55BFA2C5.20408@redhat.com> <1050814645.2742881.1438702230663.JavaMail.zimbra@redhat.com> In-Reply-To: <1050814645.2742881.1438702230663.JavaMail.zimbra@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Jan Tulak , Eric Sandeen Cc: Christoph Hellwig , xfs@oss.sgi.com On 8/4/15 8:30 AM, Jan Tulak wrote: > > > ----- Original Message ----- >> From: "Eric Sandeen" >> To: "Jan Tulak" , "Christoph Hellwig" >> Cc: xfs@oss.sgi.com >> Sent: Monday, August 3, 2015 7:20:05 PM >> Subject: Re: [PATCH v3] xfsprogs: blkid is now mandatory >> >> On 8/3/15 3:40 AM, Jan Tulak wrote: >>> >>> >>> ----- Original Message ----- >>>> From: "Christoph Hellwig" >>>> >>>> On Tue, Jul 21, 2015 at 08:39:36AM -0400, Jan Tulak wrote: >>>>> I just found that while it is possible to get blkid on OS X, it is >>>>> in 1.0.0 version which doesn't have blkid_probe_get function. >>>>> I'm examining whether it is possible to get an updated version there, >>>>> but right now, this patch breaks OS X support. Unfortunately I didn't >>>>> noticed of this before, as the OS X port was terribly out of date. >>>>> >>>>> So this patch shouldn't be included until I find how to get around. >>>> >>>> I don't think this is a lbocker given that OSX support doesn't >>>> even work. >>>> >>>> To the contrary I'd really prefer to go in ASAP to avoid anyone >>>> relying on it longer than nessecary. >>> >>> I tried to get newer blkid on OSX, but so far without a big success >>> (well, it looks like a kind of a small dependency hell that would >>> have to be ported, with bigger or smaller effort...). With regards >>> on the priorities, I think if we can make the OS X support in >>> "manual patching required" way, then? >>> >>> So lets include this patch, and just note it OS X doc "you have to revert >>> commit XXX and re-apply any changes to the relevant code"? >> >> IIRC block device signature detection isn't really required, it's just >> a nice-to-have; perhaps if blkid isn't present, that functionality can >> simply be disabled? > > Signature detection (if I understand you correctly 'signature of existing > FS') could be really disabled, I think. That would take care of > check_overwrite(). However, blkid is also used in get_topology. That one > calls blkid_get_topology, which uses blkid's functions for finding out > sector and io sizes. Well, it would be sane to default to 512 sectors; if that fails it'll be obvious fairly quickly, and the user can always use the command line to specify 4k sectors (or stripe alignment, etc) manually. > What I really can do is to say "on osx, you can mkfs only files," and cut bleah! ;) > out the blkid parts. But it limits the usage on OS X even further. > Although, the removed code for non-blkid systems used platform_findsizes > as fallback. Are there some ugly, terrible monsters who would jump from > under the bed when doing that? Well, the old findsizes was there for this reason, but now it's gone ;) > However, this patch affects only mkfs. It still should be possible to use > xfs_db and xfs_repair even on block devices. I don't know how invasive it'd be, but I think in the absence of blkid, we should still work, but lose signature detection, and fall back to geometry defaults. -Eric _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs