From: Eric Sandeen <sandeen@sandeen.net>
To: "Darrick J. Wong" <djwong@alder.djwong.org>,
david@fromorbit.com, darrick.wong@oracle.com
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 04/10] xfs_repair: fix broken EFSBADCRC/EFSCORRUPTED usage with buffer errors
Date: Mon, 17 Aug 2015 14:57:09 -0500 [thread overview]
Message-ID: <55D23C95.7090501@sandeen.net> (raw)
In-Reply-To: <55D23B3B.6060803@sandeen.net>
On 8/17/15 2:51 PM, Eric Sandeen wrote:
> On 8/14/15 8:44 PM, Darrick J. Wong wrote:
>> When we encounter CRC or verifier errors, bp->b_error is set to
>> -EFSBADCRC and -EFSCORRUPTED; note the negative sign. For whatever
>> reason, repair and db use the positive versions, and therefore fail to
>> notice the error, so fix all the broken uses.
>>
>> Note however that the db and repair turn the negative codes returned
>> by libxfs into positive codes that can be used with strerror.
>>
>> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
>
> This looks right, but I think there's more; see:
>
> XFS_WANT_CORRUPTED_GOTO
> XFS_WANT_CORRUPTED_RETURN
>
> (these return negative errors in kernelspace)
>
> and a bunch of stuff in libxlog/xfs_log_recover.c...
Ok, I guess libxlog/* was never switched to negative, and so far it looks
ok.
The XFS_WANT_CORRUPTED* macros seem like a problem, though.
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-08-17 19:57 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-15 1:43 [PATCH 00/10] xfsprogs August 2015 patchbomb Darrick J. Wong
2015-08-15 1:43 ` [PATCH 01/10] libxfs: readahead of dir3 data blocks should use the read verifier Darrick J. Wong
2015-08-17 18:31 ` Eric Sandeen
2015-08-17 20:30 ` Darrick J. Wong
2015-08-15 1:43 ` [PATCH 02/10] xfs_db: don't crash on a corrupt inode Darrick J. Wong
2015-08-17 18:52 ` Eric Sandeen
2015-08-17 20:45 ` Darrick J. Wong
2015-08-15 1:43 ` [PATCH 03/10] xfs_repair: ignore "repaired" flag after we decide to clear xattr block Darrick J. Wong
2015-08-17 19:20 ` Eric Sandeen
2015-08-17 20:50 ` Darrick J. Wong
2015-08-15 1:44 ` [PATCH 04/10] xfs_repair: fix broken EFSBADCRC/EFSCORRUPTED usage with buffer errors Darrick J. Wong
2015-08-17 19:51 ` Eric Sandeen
2015-08-17 19:57 ` Eric Sandeen [this message]
2015-08-15 1:44 ` [PATCH 05/10] xfs_repair: force not-so-bad bmbt blocks back through the verifier Darrick J. Wong
2015-08-17 21:14 ` Eric Sandeen
2015-08-17 23:48 ` Darrick J. Wong
2015-08-15 1:44 ` [PATCH 06/10] xfs_repair: mark unreachable prefetched metadata blocks stale Darrick J. Wong
2015-08-15 1:44 ` [PATCH 07/10] xfs_io: support reflinking and deduping file ranges Darrick J. Wong
2015-08-15 1:44 ` [PATCH 08/10] xfs_db: enable blocktrash for checksummed filesystems Darrick J. Wong
2015-08-18 19:26 ` Eric Sandeen
2015-08-19 15:22 ` Darrick J. Wong
2015-08-15 1:44 ` [PATCH 09/10] xfs_db: trash the block at the top of the cursor stack Darrick J. Wong
2015-08-18 19:59 ` Eric Sandeen
2015-08-19 15:12 ` Darrick J. Wong
2015-08-15 1:44 ` [PATCH 10/10] xfs_db: enable blockget for v5 filesystems Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D23C95.7090501@sandeen.net \
--to=sandeen@sandeen.net \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=djwong@alder.djwong.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox