From: Eric Sandeen <sandeen@sandeen.net>
To: Brian Foster <bfoster@redhat.com>, Jan Kara <jack@suse.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: Fix uninitialized return value in xfs_alloc_fix_freelist()
Date: Wed, 19 Aug 2015 12:40:17 -0500 [thread overview]
Message-ID: <55D4BF81.8090204@sandeen.net> (raw)
In-Reply-To: <20150715111649.GA60463@bfoster.bfoster>
On 7/15/15 6:16 AM, Brian Foster wrote:
> On Wed, Jul 15, 2015 at 10:16:08AM +0200, Jan Kara wrote:
>> xfs_alloc_fix_freelist() can sometimes jump to out_agbp_relse without
>> ever setting value of 'error' variable which is then returned. This can
>> happen e.g. when pag->pagf_init is set but AG is for metadata and we
>> want to allocate user data.
>>
>> Fix the problem by initializing 'error' to 0, which is the desired
>> return value when we decide to skip this group.
>>
>> CC: xfs@oss.sgi.com
>> Coverity-id: 1309714
>> Signed-off-by: Jan Kara <jack@suse.com>
>> ---
>
> Reviewed-by: Brian Foster <bfoster@redhat.com>
Dave, ping on this one? I don't see it in your latest update, looks important.
(xfsprogs has the same problem, FWIW)
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2015-08-19 17:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 8:16 [PATCH] xfs: Fix uninitialized return value in xfs_alloc_fix_freelist() Jan Kara
2015-07-15 11:16 ` Brian Foster
2015-08-19 17:40 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D4BF81.8090204@sandeen.net \
--to=sandeen@sandeen.net \
--cc=bfoster@redhat.com \
--cc=jack@suse.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox