From: Rich Johnston <rjohnston@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>, xfs@oss.sgi.com
Subject: Re: [PATCH 0/2] xfsdump: fix problems in cb_add_inogrp
Date: Fri, 21 Aug 2015 11:38:37 -0500 [thread overview]
Message-ID: <55D7540D.7060700@sgi.com> (raw)
In-Reply-To: <55D747FE.4070401@sandeen.net>
On 08/21/2015 10:47 AM, Eric Sandeen wrote:
> On 8/21/15 9:01 AM, rjohnston@sgi.com wrote:
>> The memset in cb_add_inogrp will segfault when the index oldsize
>> overflows. In cb_add_inogrp(), the temp variables used in
>> calculating the new i2gmap segment offset should be int64 instead
>> of intgen_t (int32).
>>
>> A second bug also occurs because we already compensate for the
>> length of each item in oldsize so are 32bit wrap becomes a 40bit
>> wrap.
>
> Hi -
>
> Are there any testcases for these? xfsdump is alien code, I swear;
> I'm not quite sure offhand how to tickle any of these bugs.
>
> Thanks,
> -Eric
>
No I thought simple examination shows the bug.
It was a customer bug.
The number of inodes that we needed before wrapping was a couple hundred
inodes.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-08-21 16:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-21 14:01 [PATCH 0/2] xfsdump: fix problems in cb_add_inogrp rjohnston
2015-08-21 14:01 ` [PATCH 1/2] xfsdump: use 64bit local variables in inode.c rjohnston
2015-08-21 17:03 ` Eric Sandeen
2015-08-21 18:22 ` Eric Sandeen
2015-08-21 14:01 ` [PATCH 2/2] xfsdump: don't do pointer math twice rjohnston
2015-08-21 17:24 ` Eric Sandeen
2015-08-21 15:47 ` [PATCH 0/2] xfsdump: fix problems in cb_add_inogrp Eric Sandeen
2015-08-21 16:38 ` Rich Johnston [this message]
2015-08-21 16:39 ` Eric Sandeen
2015-08-21 16:49 ` Rich Johnston
2015-08-21 20:08 ` Rich Johnston
2015-08-21 20:11 ` Eric Sandeen
2015-08-26 14:33 ` Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D7540D.7060700@sgi.com \
--to=rjohnston@sgi.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox