From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 38BE67F85 for ; Fri, 21 Aug 2015 11:38:42 -0500 (CDT) Message-ID: <55D7540D.7060700@sgi.com> Date: Fri, 21 Aug 2015 11:38:37 -0500 From: Rich Johnston MIME-Version: 1.0 Subject: Re: [PATCH 0/2] xfsdump: fix problems in cb_add_inogrp References: <20150821193047.661578219@gulag1.americas.sgi.com> <55D747FE.4070401@sandeen.net> In-Reply-To: <55D747FE.4070401@sandeen.net> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: Eric Sandeen , xfs@oss.sgi.com On 08/21/2015 10:47 AM, Eric Sandeen wrote: > On 8/21/15 9:01 AM, rjohnston@sgi.com wrote: >> The memset in cb_add_inogrp will segfault when the index oldsize >> overflows. In cb_add_inogrp(), the temp variables used in >> calculating the new i2gmap segment offset should be int64 instead >> of intgen_t (int32). >> >> A second bug also occurs because we already compensate for the >> length of each item in oldsize so are 32bit wrap becomes a 40bit >> wrap. > > Hi - > > Are there any testcases for these? xfsdump is alien code, I swear; > I'm not quite sure offhand how to tickle any of these bugs. > > Thanks, > -Eric > No I thought simple examination shows the bug. It was a customer bug. The number of inodes that we needed before wrapping was a couple hundred inodes. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs