From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <xfs-bounces@oss.sgi.com>
Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29])
	by oss.sgi.com (Postfix) with ESMTP id 861377F88
	for <xfs@oss.sgi.com>; Fri, 21 Aug 2015 11:49:54 -0500 (CDT)
Message-ID: <55D756B0.30402@sgi.com>
Date: Fri, 21 Aug 2015 11:49:52 -0500
From: Rich Johnston <rjohnston@sgi.com>
MIME-Version: 1.0
Subject: Re: [PATCH 0/2] xfsdump: fix problems in cb_add_inogrp
References: <20150821193047.661578219@gulag1.americas.sgi.com>
	<55D747FE.4070401@sandeen.net> <55D7540D.7060700@sgi.com>
	<55D75454.1060003@sandeen.net>
In-Reply-To: <55D75454.1060003@sandeen.net>
List-Id: XFS Filesystem from SGI <xfs.oss.sgi.com>
List-Unsubscribe: <http://oss.sgi.com/mailman/options/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=unsubscribe>
List-Archive: <http://oss.sgi.com/pipermail/xfs>
List-Post: <mailto:xfs@oss.sgi.com>
List-Help: <mailto:xfs-request@oss.sgi.com?subject=help>
List-Subscribe: <http://oss.sgi.com/mailman/listinfo/xfs>,
	<mailto:xfs-request@oss.sgi.com?subject=subscribe>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: xfs-bounces@oss.sgi.com
Sender: xfs-bounces@oss.sgi.com
To: Eric Sandeen <sandeen@sandeen.net>, xfs@oss.sgi.com

On 08/21/2015 11:39 AM, Eric Sandeen wrote:
> On 8/21/15 11:38 AM, Rich Johnston wrote:
>> On 08/21/2015 10:47 AM, Eric Sandeen wrote:
>>> On 8/21/15 9:01 AM, rjohnston@sgi.com wrote:
>>>> The memset in cb_add_inogrp will segfault when the index oldsize
>>>> overflows. In cb_add_inogrp(), the temp variables used in
>>>> calculating the new i2gmap segment offset should be int64 instead
>>>> of intgen_t (int32).
>>>>
>>>> A second bug also occurs because we already compensate for the
>>>> length of each item in oldsize so are 32bit wrap becomes a 40bit
>>>> wrap.
>>>
>>> Hi -
>>>
>>> Are there any testcases for these?  xfsdump is alien code, I swear;
>>> I'm not quite sure offhand how to tickle any of these bugs.
>>>
>>> Thanks,
>>> -Eric
>>>
>> No I thought simple examination shows the bug.
>
> Nothing is simple in xfsdump, IMHO.  At least to the uninitiated.  :)
>
:)
>> It was a customer bug.
>>
>> The number of inodes that we needed before wrapping was a couple hundred inodes.
                                                                     ^^^^
make that *million*
>
> I did eventually manage to hit the segfault, thanks.
>
> -Eric
>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs