[PATCH] xfs_repair: set args.geo in longform_dir2_entry_check_data

[PATCH] xfs_repair: set args.geo in longform_dir2_entry_check_data

[Eric Sandeen]

Here's another one where we miss setting da_args->geo:

longform_dir2_entry_check_data
        struct xfs_da_args      da = {
                .dp = ip,
		// .geo is unset
        };
...
	libxfs_dir2_data_make_free(&da ...)
		xfs_dir2_data_make_free
			endptr = (char *)hdr + args->geo->blksize;
				BOOM

Addresses-Coverity-Id: 1298008
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---

Have to wonder if there are more of these :(

diff --git a/repair/phase6.c b/repair/phase6.c
index 04638c2..951587e 100644
--- a/repair/phase6.c
+++ b/repair/phase6.c
@@ -1506,6 +1506,7 @@ longform_dir2_entry_check_data(
 	int			wantmagic;
 	struct xfs_da_args	da = {
 		.dp = ip,
+		.geo = mp->m_dir_geo,
 	};
 
 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs_repair: set args.geo in longform_dir2_entry_check_data

[Dave Chinner]

On Tue, Aug 25, 2015 at 01:34:21PM -0500, Eric Sandeen wrote:
> Here's another one where we miss setting da_args->geo:
> 
> longform_dir2_entry_check_data
>         struct xfs_da_args      da = {
>                 .dp = ip,
> 		// .geo is unset
>         };
> ...
> 	libxfs_dir2_data_make_free(&da ...)
> 		xfs_dir2_data_make_free
> 			endptr = (char *)hdr + args->geo->blksize;
> 				BOOM
> 
> Addresses-Coverity-Id: 1298008
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
> 
> Have to wonder if there are more of these :(

A quick git grep shows 3 uses of the struct xfs_da_args outside
libxfs. longform_dir2_entry_check() is already fixed, this fixes
longform_dir2_entry_check_data(), and dir2_kill_block() still needs
fixing.

AFAICT all the libxfs/ usage is good.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfs_repair: set args.geo in longform_dir2_entry_check_data

[Eric Sandeen]

On 8/25/15 1:34 PM, Eric Sandeen wrote:
> Here's another one where we miss setting da_args->geo:
> 
> longform_dir2_entry_check_data
>         struct xfs_da_args      da = {
>                 .dp = ip,
> 		// .geo is unset
>         };
> ...
> 	libxfs_dir2_data_make_free(&da ...)
> 		xfs_dir2_data_make_free
> 			endptr = (char *)hdr + args->geo->blksize;
> 				BOOM
> 
> Addresses-Coverity-Id: 1298008
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
> 
> Have to wonder if there are more of these :(

Spot-checking in userspace wasn't hard; doesn't look like there are any more.

kernelspace looks ok too.

-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs