From: Rich Johnston <rjohnston@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>, xfs@oss.sgi.com
Subject: Re: [PATCH 0/2] xfsdump: fix problems in cb_add_inogrp
Date: Wed, 26 Aug 2015 09:33:54 -0500 [thread overview]
Message-ID: <55DDCE52.9070105@sgi.com> (raw)
In-Reply-To: <55D785E7.8050503@sandeen.net>
On 08/21/2015 03:11 PM, Eric Sandeen wrote:
> On 8/21/15 3:08 PM, Rich Johnston wrote:
>> On 08/21/2015 10:47 AM, Eric Sandeen wrote:
>>> Hi -
>>>
>>> Are there any testcases for these? xfsdump is alien code, I swear;
>>> I'm not quite sure offhand how to tickle any of these bugs.
>>>
>>> Thanks,
>>> -Eric
>>>
>>
>> Hey Eric,
>>
>> Many thanks for taking the time to review these patches.
>> I take a look at all your responses and get a V2 out early next week.
>
> Sounds good. If I was off track about the need for the extra 64-bit vars,
> just educate me. ;)
>
> -Eric
>
Ok you convinced me, there is no need for patch 1 and patch 2 can be
solved by removing the local variable oldsize.
A new patch has been submitted.
[PATCH] xfsdump: prevent segfault in cb_add_inogrp
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2015-08-26 14:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-21 14:01 [PATCH 0/2] xfsdump: fix problems in cb_add_inogrp rjohnston
2015-08-21 14:01 ` [PATCH 1/2] xfsdump: use 64bit local variables in inode.c rjohnston
2015-08-21 17:03 ` Eric Sandeen
2015-08-21 18:22 ` Eric Sandeen
2015-08-21 14:01 ` [PATCH 2/2] xfsdump: don't do pointer math twice rjohnston
2015-08-21 17:24 ` Eric Sandeen
2015-08-21 15:47 ` [PATCH 0/2] xfsdump: fix problems in cb_add_inogrp Eric Sandeen
2015-08-21 16:38 ` Rich Johnston
2015-08-21 16:39 ` Eric Sandeen
2015-08-21 16:49 ` Rich Johnston
2015-08-21 20:08 ` Rich Johnston
2015-08-21 20:11 ` Eric Sandeen
2015-08-26 14:33 ` Rich Johnston [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DDCE52.9070105@sgi.com \
--to=rjohnston@sgi.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox