Re: [PATCH 02/13] xfs_repair: remove type from da & dir2 cursors

Brian Foster
2015-09-14T19:18:10Z

On Wed, Sep 09, 2015 at 02:34:00PM -0500, Eric Sandeen wrote:
> The type field in these cursors is only set (and only
> in the attr code), and it's never read; just remove
> it.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> ---

Reviewed-by: Brian Foster <bfoster@redhat.com>

> repair/attr_repair.c | 2 --
> repair/dir2.h | 1 -
> 2 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/repair/attr_repair.c b/repair/attr_repair.c
> index d63bc87..f29a5bd 100644
> --- a/repair/attr_repair.c
> +++ b/repair/attr_repair.c
> @@ -67,7 +67,6 @@ typedef struct da_level_state {
>
> typedef struct da_bt_cursor {
> int active; /* highest level in tree (# levels-1) */
> - int type; /* 0 if dir, 1 if attr */
> xfs_ino_t ino;
> xfs_dablk_t greatest_bno;
> xfs_dinode_t *dip;
> @@ -1477,7 +1476,6 @@ process_node_attr(
> */
> memset(&da_cursor, 0, sizeof(da_bt_cursor_t));
> da_cursor.active = 0;
> - da_cursor.type = 0;
> da_cursor.ino = ino;
> da_cursor.dip = dip;
> da_cursor.greatest_bno = 0;
> diff --git a/repair/dir2.h b/repair/dir2.h
> index df68d5c..3cc1941 100644
> --- a/repair/dir2.h
> +++ b/repair/dir2.h
> @@ -51,7 +51,6 @@ typedef struct dir2_level_state {
>
> typedef struct dir2_bt_cursor {
> int active; /* highest level in tree (# levels-1) */
> - int type; /* 0 if dir, 1 if attr */
> xfs_ino_t ino;
> xfs_dablk_t greatest_bno;
> xfs_dinode_t *dip;
> --
> 1.7.1
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs