From: Eric Sandeen <sandeen@sandeen.net>
To: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix build without xfsstats
Date: Fri, 16 Oct 2015 19:08:01 -0500 [thread overview]
Message-ID: <56219161.8020408@sandeen.net> (raw)
In-Reply-To: <5578984.gxbqPUmtuT@wuerfel>
On 10/16/15 4:47 PM, Arnd Bergmann wrote:
> A recent rework of the xfsstats interface introduced a compile error
> for the procfs-disabled case:
>
> fs/built-in.o: In function `xfs_free_ag_extent':
> fs/xfs/libxfs/xfs_alloc.c:1725: undefined reference to `xfsstats'
> fs/built-in.o: In function `xfs_alloc_ag_vextent':
> fs/xfs/libxfs/xfs_alloc.c:645: undefined reference to `xfsstats'
> fs/built-in.o: In function `xfs_attr_set':
> fs/xfs/libxfs/xfs_attr.c:353: undefined reference to `xfsstats'
> fs/built-in.o: In function `xfs_attr_remove':
> fs/xfs/libxfs/xfs_attr.c:483: undefined reference to `xfsstats'
> fs/built-in.o: In function `xfs_attr_get':
> fs/xfs/libxfs/xfs_attr.c:131: undefined reference to `xfsstats'
> fs/built-in.o:fs/xfs/libxfs/xfs_bmap.c:1461: more undefined references to `xfsstats' follow
>
> This adds conditional compilation to each reference of the xfsstats
> global variable to get it to link again.
>
> An alternative approach would be to always build the statistics
> implementation even when CONFIG_PROC_FS is disabled.
Yep, they live for realz in sysfs now, not procfs.
Reported a couple times already ;) Dave has a patch at:
https://marc.info/?l=linux-xfs&m=144476889031721&w=2
Thanks,
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2015-10-17 0:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-16 21:47 [PATCH] xfs: fix build without xfsstats Arnd Bergmann
2015-10-17 0:08 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56219161.8020408@sandeen.net \
--to=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox