From: Avi Kivity <avi@scylladb.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Brian Foster <bfoster@redhat.com>,
Glauber Costa <glauber@scylladb.com>,
xfs@oss.sgi.com
Subject: Re: sleeps and waits during io_submit
Date: Tue, 8 Dec 2015 15:56:52 +0200 [thread overview]
Message-ID: <5666E1A4.4070805@scylladb.com> (raw)
In-Reply-To: <20151208060343.GC19802@dastard>
On 12/08/2015 08:03 AM, Dave Chinner wrote:
> On Wed, Dec 02, 2015 at 10:34:14AM +0200, Avi Kivity wrote:
>> On 12/02/2015 02:13 AM, Brian Foster wrote:
>>> Metadata is modified in-core and handed off to the logging
>>> infrastructure via a transaction. The log is flushed to disk some time
>>> later and metadata writeback occurs asynchronously via the xfsaild
>>> thread.
>> Unless, I expect, if the log is full. Since we're hammering on the
>> disk quite heavily, the log would be fighting with user I/O and
>> possibly losing.
>>
>> Does XFS throttle user I/O in order to get the log buffers recycled faster?
> No. XFS tags the metadata IO with REQ_META that the IO schedulers
> can tell the difference between metadata and data IO, and schedule
> them appropriately. Further. log buffers are also tagged with
> REQ_SYNC to indicate they are latency sensitive IOs, whcih the IO
> schedulers again treat differently to minimise latency in the face
> of bulk async IO which is not latency sensitive.
>
> IOWs, IO prioritisation and dispatch scheduling is the job of the IO
> scheduler, not the filesystem. The filesystem just tells the
> scheduler how to treat the different types of IO...
>
>> Is there any way for us to keep track of it, and reduce disk
>> pressure when it gets full?
> Only if you want to make more problems for yourself - second
> guessing what the filesystem is going to do will only lead you to
> dancing the Charlie Foxtrot on a regular basis. :/
So far the best approach I found that doesn't conflict with this is to
limit io_submit iodepth to the natural disk iodepth (or a small multiple
thereof). This seems to keep XFS in its comfort zone, and is good for
latency anyway.
The only issue is that the only way to obtain this parameter is to
measure it.
I wrote a small tool to do this [1], but it's a hassle for users.
[1] https://github.com/avikivity/diskplorer
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-12-08 13:56 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-28 2:43 sleeps and waits during io_submit Glauber Costa
2015-11-30 14:10 ` Brian Foster
2015-11-30 14:29 ` Avi Kivity
2015-11-30 16:14 ` Brian Foster
2015-12-01 9:08 ` Avi Kivity
2015-12-01 13:11 ` Brian Foster
2015-12-01 13:58 ` Avi Kivity
2015-12-01 14:01 ` Glauber Costa
2015-12-01 14:37 ` Avi Kivity
2015-12-01 20:45 ` Dave Chinner
2015-12-01 20:56 ` Avi Kivity
2015-12-01 23:41 ` Dave Chinner
2015-12-02 8:23 ` Avi Kivity
2015-12-01 14:56 ` Brian Foster
2015-12-01 15:22 ` Avi Kivity
2015-12-01 16:01 ` Brian Foster
2015-12-01 16:08 ` Avi Kivity
2015-12-01 16:29 ` Brian Foster
2015-12-01 17:09 ` Avi Kivity
2015-12-01 18:03 ` Carlos Maiolino
2015-12-01 19:07 ` Avi Kivity
2015-12-01 21:19 ` Dave Chinner
2015-12-01 21:38 ` Avi Kivity
2015-12-01 23:06 ` Dave Chinner
2015-12-02 9:02 ` Avi Kivity
2015-12-02 12:57 ` Carlos Maiolino
2015-12-02 23:19 ` Dave Chinner
2015-12-03 12:52 ` Avi Kivity
2015-12-04 3:16 ` Dave Chinner
2015-12-08 13:52 ` Avi Kivity
2015-12-08 23:13 ` Dave Chinner
2015-12-01 18:51 ` Brian Foster
2015-12-01 19:07 ` Glauber Costa
2015-12-01 19:35 ` Brian Foster
2015-12-01 19:45 ` Avi Kivity
2015-12-01 19:26 ` Avi Kivity
2015-12-01 19:41 ` Christoph Hellwig
2015-12-01 19:50 ` Avi Kivity
2015-12-02 0:13 ` Brian Foster
2015-12-02 0:57 ` Dave Chinner
2015-12-02 8:38 ` Avi Kivity
2015-12-02 8:34 ` Avi Kivity
2015-12-08 6:03 ` Dave Chinner
2015-12-08 13:56 ` Avi Kivity [this message]
2015-12-08 23:32 ` Dave Chinner
2015-12-09 8:37 ` Avi Kivity
2015-12-01 21:04 ` Dave Chinner
2015-12-01 21:10 ` Glauber Costa
2015-12-01 21:39 ` Dave Chinner
2015-12-01 21:24 ` Avi Kivity
2015-12-01 21:31 ` Glauber Costa
2015-11-30 15:49 ` Glauber Costa
2015-12-01 13:11 ` Brian Foster
2015-12-01 13:39 ` Glauber Costa
2015-12-01 14:02 ` Brian Foster
2015-11-30 23:10 ` Dave Chinner
2015-11-30 23:51 ` Glauber Costa
2015-12-01 20:30 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5666E1A4.4070805@scylladb.com \
--to=avi@scylladb.com \
--cc=bfoster@redhat.com \
--cc=david@fromorbit.com \
--cc=glauber@scylladb.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox