From: Eric Sandeen <sandeen@sandeen.net>
To: xfs@oss.sgi.com
Subject: Re: [PATCH] XFS: Use a signed return type for suffix_kstrtoint()
Date: Mon, 21 Dec 2015 12:35:55 -0600 [thread overview]
Message-ID: <5678468B.1040008@sandeen.net> (raw)
In-Reply-To: <5676520D.2060806@users.sourceforge.net>
On 12/20/15 1:00 AM, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Sun, 20 Dec 2015 07:56:36 +0100
>
> The return type "unsigned long" was used by the suffix_kstrtoint()
> function even though it will eventually return a negative error code.
> Improve this implementation detail by using the type "int" instead.
>
> This issue was detected by using the Coccinelle software.
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
yep, looks like an oversight left over from a17164e5
Harmless, because callers only check for non-zero value, but still
worth fixing.
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Thanks,
-Eric
> ---
> fs/xfs/xfs_super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index 436b6ef..59c9b7b 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -137,7 +137,7 @@ static const match_table_t tokens = {
> };
>
>
> -STATIC unsigned long
> +STATIC int
> suffix_kstrtoint(char *s, unsigned int base, int *res)
> {
> int last, shift_left_factor = 0, _res;
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-12-21 18:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-20 7:00 [PATCH] XFS: Use a signed return type for suffix_kstrtoint() SF Markus Elfring
2015-12-21 18:35 ` Eric Sandeen [this message]
2015-12-21 21:53 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5678468B.1040008@sandeen.net \
--to=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox