From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 1204F7F54 for ; Sat, 9 Jan 2016 18:57:03 -0600 (CST) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay3.corp.sgi.com (Postfix) with ESMTP id 8EBEAAC002 for ; Sat, 9 Jan 2016 16:57:02 -0800 (PST) Received: from sabe.cs.wisc.edu (sabe.cs.wisc.edu [128.105.6.20]) by cuda.sgi.com with ESMTP id UEr8VH0zBEZXqNOk (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO) for ; Sat, 09 Jan 2016 16:57:00 -0800 (PST) Message-ID: <5691AC2E.2050403@cs.wisc.edu> Date: Sat, 09 Jan 2016 18:56:14 -0600 From: Mike Christie MIME-Version: 1.0 Subject: Re: [dm-devel] [PATCH 02/35] block: add REQ_OP definitions and bi_op/op fields References: <1452027218-32303-1-git-send-email-mchristi@redhat.com> <1452027218-32303-3-git-send-email-mchristi@redhat.com> <20160109133716.GB26660@infradead.org> In-Reply-To: <20160109133716.GB26660@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: device-mapper development , mchristi@redhat.com Cc: linux-raid@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-scsi@vger.kernel.org, konrad.wilk@oracle.com, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, xfs@oss.sgi.com, linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, target-devel@vger.kernel.org, linux-mtd@lists.infradead.org, osd-dev@open-osd.org, linux-fsdevel@vger.kernel.org, lars.ellenberg@linbit.com, philipp.reisner@linbit.com, drbd-dev@lists.linbit.com, ocfs2-devel@oss.oracle.com, linux-btrfs@vger.kernel.org On 01/09/2016 07:37 AM, Christoph Hellwig wrote: > Seems like this is missing REQ_OP_FLUSH, which still hides as a write? > I might have misunderstood what you wanted or am misunderstanding you now. I did not change the flush related code until the last patches. I added REQ_OP_FLUSH in patch: [PATCH 33/35] block, drivers: add REQ_OP_FLUSH operation commit 18dea20363ba245a47bc1bb54f6465b8a05b19af Author: Mike Christie Date: Tue Jan 5 21:02:17 2016 -0600 block, drivers: add REQ_OP_FLUSH operation and I added the REQ_PREFLUSH flag in [PATCH 35/35] block, drivers, fs: rename REQ_FLUSH to REQ_PREFLUSH commit 303dc6a7cc3673065538ba041562fcd833a619af Author: Mike Christie Date: Thu Jan 7 18:17:03 2016 -0600 block, drivers, fs: rename REQ_FLUSH to REQ_PREFLUSH I did them in separate patches, because I was not sure if they were correct with what you requested before, and because they were a little more tricky because of how request_fn drivers, make_request_fn drivers, and dm-multipath handle flushes differently. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs