From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay2.corp.sgi.com [137.38.102.29]) by oss.sgi.com (Postfix) with ESMTP id 41FE17F37 for ; Sat, 23 Jan 2016 12:03:08 -0600 (CST) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay2.corp.sgi.com (Postfix) with ESMTP id 14911304039 for ; Sat, 23 Jan 2016 10:03:07 -0800 (PST) Received: from sandeen.net (sandeen.net [63.231.237.45]) by cuda.sgi.com with ESMTP id vzfbSaG8DIE8osek for ; Sat, 23 Jan 2016 10:03:02 -0800 (PST) Received: from liberator.sandeen.net (liberator.sandeen.net [10.0.0.4]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by sandeen.net (Postfix) with ESMTPSA id 7E5D963D5841 for ; Sat, 23 Jan 2016 12:03:01 -0600 (CST) Subject: Re: [PATCH 1/5] xfs_io: detect the '-R' option in getopt References: <20160123003502.2475.99558.stgit@birch.djwong.org> <56A307D8.60202@sandeen.net> <20160123061811.GC5500@birch.djwong.org> From: Eric Sandeen Message-ID: <56A3C054.4000804@sandeen.net> Date: Sat, 23 Jan 2016 12:03:00 -0600 MIME-Version: 1.0 In-Reply-To: <20160123061811.GC5500@birch.djwong.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: xfs@oss.sgi.com On 1/23/16 12:18 AM, Darrick J. Wong wrote: > On Fri, Jan 22, 2016 at 10:55:52PM -0600, Eric Sandeen wrote: >> On 1/22/16 6:35 PM, Darrick J. Wong wrote: >>> Configure getopt to accept the -R argument to pwrite. >> >> Did you have anything against "F" and "B"? :) >> >> (They're missing too but in the case statements & help) > > No, but I /was/ wondering if the omission was deliberate? I don't think so; the commit that added it (8fb2237) seemed to do everything but add the getopt chars. Oh, and however much gets fixed up, probably needs a man page update too. Thanks, -Eric > --D > >> >> -Eric >> >>> Signed-off-by: Darrick J. Wong >>> --- >>> io/pwrite.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> >>> diff --git a/io/pwrite.c b/io/pwrite.c >>> index fd9114d..c6efee9 100644 >>> --- a/io/pwrite.c >>> +++ b/io/pwrite.c >>> @@ -259,7 +259,7 @@ pwrite_f( >>> init_cvtnum(&fsblocksize, &fssectsize); >>> bsize = fsblocksize; >>> >>> - while ((c = getopt(argc, argv, "b:Cdf:i:qs:S:uV:wWZ:")) != EOF) { >>> + while ((c = getopt(argc, argv, "b:Cdf:i:qRs:S:uV:wWZ:")) != EOF) { >>> switch (c) { >>> case 'b': >>> tmp = cvtnum(fsblocksize, fssectsize, optarg); >>> >>> _______________________________________________ >>> xfs mailing list >>> xfs@oss.sgi.com >>> http://oss.sgi.com/mailman/listinfo/xfs >>> >> >> _______________________________________________ >> xfs mailing list >> xfs@oss.sgi.com >> http://oss.sgi.com/mailman/listinfo/xfs > > _______________________________________________ > xfs mailing list > xfs@oss.sgi.com > http://oss.sgi.com/mailman/listinfo/xfs > _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs