From: Eric Sandeen <sandeen@sandeen.net>
To: xfs@oss.sgi.com
Subject: [PATCH] xfs_repair: Fix untranslatable strings
Date: Sun, 24 Jan 2016 11:08:24 -0600 [thread overview]
Message-ID: <56A50508.4060207@sandeen.net> (raw)
In-Reply-To: <20160124155853.GA10063@stranger.qboosh.pl>
Don't substitute in "would" or "will" for %s here, it makes
it untranslatable. Just spell it out twice like every other
message in the function.
Reported-by: Jakub Bogusz <qboosh@pld-linux.org>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---
diff --git a/repair/versions.c b/repair/versions.c
index 1585385..978f48b 100644
--- a/repair/versions.c
+++ b/repair/versions.c
@@ -224,10 +224,17 @@ _("WARNING: you have disallowed attr2 attributes but this filesystem\n"
}
if (!(sb->sb_versionnum & XFS_SB_VERSION_NLINKBIT)) {
- do_warn(
-_("WARNING: you have a V1 inode filesystem. It %s be converted to a\n"
+ if (!no_modify) {
+ do_warn(
+_("WARNING: you have a V1 inode filesystem. It will be converted to a\n"
"\tversion 2 inode filesystem. If you do not want this, run an older\n"
- "\tversion of xfs_repair.\n"), no_modify ? "would" : "will");
+ "\tversion of xfs_repair.\n"));
+ } else {
+ do_warn(
+_("WARNING: you have a V1 inode filesystem. It would be converted to a\n"
+ "\tversion 2 inode filesystem. If you do not want this, run an older\n"
+ "\tversion of xfs_repair.\n"));
+ }
}
if (xfs_sb_version_hasquota(sb)) {
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-01-24 17:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-24 15:58 Polish translation update + localization remark for xfsprogs 4.3.0 Jakub Bogusz
2016-01-24 17:08 ` Eric Sandeen [this message]
2016-01-26 16:47 ` [PATCH] xfs_repair: Fix untranslatable strings Christoph Hellwig
2016-01-26 16:47 ` Polish translation update + localization remark for xfsprogs 4.3.0 Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A50508.4060207@sandeen.net \
--to=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox