* [PATCH 0/2] xfsprogs: minor quota fixups
@ 2016-01-27 22:49 Eric Sandeen
2016-01-27 22:50 ` [PATCH 1/2] xfs_quota: remove extra 30 seconds from time limit reporting Eric Sandeen
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Eric Sandeen @ 2016-01-27 22:49 UTC (permalink / raw)
To: xfs
Small fixups encountered while digging through quota...
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] xfs_quota: remove extra 30 seconds from time limit reporting
2016-01-27 22:49 [PATCH 0/2] xfsprogs: minor quota fixups Eric Sandeen
@ 2016-01-27 22:50 ` Eric Sandeen
2016-01-27 22:51 ` [PATCH 2/2] xfs_quota: fix up timer command help Eric Sandeen
2016-01-28 13:02 ` [PATCH 0/2] xfsprogs: minor quota fixups Carlos Maiolino
2 siblings, 0 replies; 4+ messages in thread
From: Eric Sandeen @ 2016-01-27 22:50 UTC (permalink / raw)
To: xfs
The addition of 30s makes little sense; it's only added to the
values reported via the userspace tool, and doesn't reflect the
actual values used in the kernel. Setting a time limit to
"00:30:00" and reporting back "00:30:30" makes little sense to me.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/quota/util.c b/quota/util.c
index 179aafd..7c43fbd 100644
--- a/quota/util.c
+++ b/quota/util.c
@@ -42,8 +42,6 @@ time_to_string(
time(&now);
timer = MAX(origin - now, 0);
}
- if (timer > 60) /* roundup */
- timer += 30;
days = timer / SECONDS_IN_A_DAY;
if (days)
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] xfs_quota: fix up timer command help
2016-01-27 22:49 [PATCH 0/2] xfsprogs: minor quota fixups Eric Sandeen
2016-01-27 22:50 ` [PATCH 1/2] xfs_quota: remove extra 30 seconds from time limit reporting Eric Sandeen
@ 2016-01-27 22:51 ` Eric Sandeen
2016-01-28 13:02 ` [PATCH 0/2] xfsprogs: minor quota fixups Carlos Maiolino
2 siblings, 0 replies; 4+ messages in thread
From: Eric Sandeen @ 2016-01-27 22:51 UTC (permalink / raw)
To: xfs
The timer command help output suggests that either default, or a
specific ID, can be specified, but this is not the case. Timers
are fs-wide for each quota type, not specific to the user. So
remove the "-d|id|name" from the help output. Also remove
"get" from the description, because it only sets these timers;
"state" returns their values. Well actually just one of them,
but that's a different problem...
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/quota/edit.c b/quota/edit.c
index c55fa1a..6146f7e 100644
--- a/quota/edit.c
+++ b/quota/edit.c
@@ -701,8 +701,8 @@ edit_init(void)
timer_cmd.cfunc = timer_f;
timer_cmd.argmin = 2;
timer_cmd.argmax = -1;
- timer_cmd.args = _("[-bir] [-gpu] value -d|id|name");
- timer_cmd.oneline = _("get/set quota enforcement timeouts");
+ timer_cmd.args = _("[-bir] [-gpu] value");
+ timer_cmd.oneline = _("set quota enforcement timeouts");
timer_cmd.help = timer_help;
warn_cmd.name = "warn";
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] xfsprogs: minor quota fixups
2016-01-27 22:49 [PATCH 0/2] xfsprogs: minor quota fixups Eric Sandeen
2016-01-27 22:50 ` [PATCH 1/2] xfs_quota: remove extra 30 seconds from time limit reporting Eric Sandeen
2016-01-27 22:51 ` [PATCH 2/2] xfs_quota: fix up timer command help Eric Sandeen
@ 2016-01-28 13:02 ` Carlos Maiolino
2 siblings, 0 replies; 4+ messages in thread
From: Carlos Maiolino @ 2016-01-28 13:02 UTC (permalink / raw)
To: Eric Sandeen; +Cc: xfs
Makes sense to me, consider it
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
On Wed, Jan 27, 2016 at 04:49:32PM -0600, Eric Sandeen wrote:
> Small fixups encountered while digging through quota...
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
--
Carlos
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-28 13:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-27 22:49 [PATCH 0/2] xfsprogs: minor quota fixups Eric Sandeen
2016-01-27 22:50 ` [PATCH 1/2] xfs_quota: remove extra 30 seconds from time limit reporting Eric Sandeen
2016-01-27 22:51 ` [PATCH 2/2] xfs_quota: fix up timer command help Eric Sandeen
2016-01-28 13:02 ` [PATCH 0/2] xfsprogs: minor quota fixups Carlos Maiolino
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox