From: Eric Sandeen <sandeen@redhat.com>
To: xfs@oss.sgi.com
Subject: [PATCH] xfs: lock bitmap/summary inodes in xfs_rtbuf_get()
Date: Fri, 29 Jan 2016 21:26:28 -0600 [thread overview]
Message-ID: <56AC2D64.2080907@redhat.com> (raw)
Commit eef334e added an ASSERT that the inode was locked in
some way in xfs_bmapi_read(), but on realtime paths through
xfs_rtbuf_get() this isn't the case; fix that.
Reported-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
I think we need the data_map_shared gyrations here, but not certain...
diff --git a/fs/xfs/libxfs/xfs_rtbitmap.c b/fs/xfs/libxfs/xfs_rtbitmap.c
index 9b59ffa..e6da0b2 100644
--- a/fs/xfs/libxfs/xfs_rtbitmap.c
+++ b/fs/xfs/libxfs/xfs_rtbitmap.c
@@ -57,11 +57,14 @@ xfs_rtbuf_get(
xfs_inode_t *ip; /* bitmap or summary inode */
xfs_bmbt_irec_t map;
int nmap = 1;
+ int lock_mode;
int error; /* error value */
ip = issum ? mp->m_rsumip : mp->m_rbmip;
+ lock_mode = xfs_ilock_data_map_shared(ip);
error = xfs_bmapi_read(ip, block, 1, &map, &nmap, XFS_DATA_FORK);
+ xfs_iunlock(ip, lock_mode);
if (error)
return error;
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2016-01-30 3:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-30 3:26 Eric Sandeen [this message]
2016-01-30 21:06 ` [PATCH] xfs: lock bitmap/summary inodes in xfs_rtbuf_get() Dave Chinner
2016-01-30 21:53 ` Eric Sandeen
2016-02-01 22:05 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AC2D64.2080907@redhat.com \
--to=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox