From: Eric Sandeen <sandeen@sandeen.net>
To: xfs@oss.sgi.com
Subject: Re: [PATCH 1/3] xfs: lock rt summary inode on allocation
Date: Mon, 1 Feb 2016 19:26:50 -0600 [thread overview]
Message-ID: <56B005DA.2030200@sandeen.net> (raw)
In-Reply-To: <1454373550-3102-2-git-send-email-david@fromorbit.com>
On 2/1/16 6:39 PM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> RT allocation can fail on a debug kernel with:
>
> XFS: Assertion failed: xfs_isilocked(ip, XFS_ILOCK_SHARED|XFS_ILOCK_EXCL), file: fs/xfs/libxfs/xfs_bmap.c, line: 4039
>
> When modifying the summary inode during allocation. This occurs
> because the summary inode is never locked, and xfs_bmapi_*
> operations expect it to be locked. The summary inode is effectively
> protected byt he lock on the bitmap inode, so this really is only a
> debug kernel issue.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Oh, it was easy after all...
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> fs/xfs/xfs_bmap_util.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_bmap_util.c b/fs/xfs/xfs_bmap_util.c
> index 7087756..fd7f51c 100644
> --- a/fs/xfs/xfs_bmap_util.c
> +++ b/fs/xfs/xfs_bmap_util.c
> @@ -202,10 +202,12 @@ xfs_bmap_rtalloc(
> ralen = MAXEXTLEN / mp->m_sb.sb_rextsize;
>
> /*
> - * Lock out other modifications to the RT bitmap inode.
> + * Lock out modifications to both the RT bitmap and summary inodes
> */
> xfs_ilock(mp->m_rbmip, XFS_ILOCK_EXCL);
> xfs_trans_ijoin(ap->tp, mp->m_rbmip, XFS_ILOCK_EXCL);
> + xfs_ilock(mp->m_rsumip, XFS_ILOCK_EXCL);
> + xfs_trans_ijoin(ap->tp, mp->m_rsumip, XFS_ILOCK_EXCL);
>
> /*
> * If it's an allocation to an empty file at offset 0,
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-02-02 1:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 0:39 [PATCH 0/3] xfs: fix realtime device assert failures Dave Chinner
2016-02-02 0:39 ` [PATCH 1/3] xfs: lock rt summary inode on allocation Dave Chinner
2016-02-02 1:26 ` Eric Sandeen [this message]
2016-02-02 0:39 ` [PATCH 2/3] xfs: RT bitmap and summary buffers are not typed Dave Chinner
2016-02-02 1:26 ` Eric Sandeen
2016-02-02 0:39 ` [PATCH 3/3] xfs: RT bitmap and summary buffers need verifiers Dave Chinner
2016-02-02 1:25 ` Eric Sandeen
2016-02-04 21:22 ` [PATCH 0/3] xfs: fix realtime device assert failures Ross Zwisler
2016-02-05 22:35 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B005DA.2030200@sandeen.net \
--to=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox