From: Eric Sandeen <sandeen@sandeen.net>
To: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2 v3] xfs_repair: new secondary superblock search method
Date: Fri, 12 Feb 2016 08:18:38 -0600 [thread overview]
Message-ID: <56BDE9BE.9030300@sandeen.net> (raw)
In-Reply-To: <56BD2500.4080708@sandeen.net>
On 2/11/16 6:19 PM, Eric Sandeen wrote:
> Hi Bill, looks like this is a diff on top of your prior patch,
> not a standalone patch. It's modifying (not creating) libxcmd/topology.c,
> which doesn't exist upstream yet.
Sorry, I apologize - this was patch 2 of 2, and I didn't have patch 1
applied. It's easier to spot dependencies when a series stays properly
threaded, though. :)
And best to not fix issues with patch 1 in patch 2; just fix things
in the original patch which introduced it.
i.e. this:
--- a/libxcmd/topology.c
+++ b/libxcmd/topology.c
@@ -192,7 +192,8 @@ out:
return ret;
}
-static void blkid_get_topology(
+static void
+blkid_get_topology(
const char *device,
int *sunit,
int *swidth,
@@ -284,7 +285,8 @@ check_overwrite(
return 1;
}
should all just be formatted as you want it in patch 1.
Thanks,
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2016-02-12 14:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 18:50 [PATCH 2/2 v3] xfs_repair: new secondary superblock search method Bill O'Donnell
2016-02-12 0:19 ` Eric Sandeen
2016-02-12 14:18 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BDE9BE.9030300@sandeen.net \
--to=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox