From: Eric Sandeen <sandeen@sandeen.net>
To: xfs@oss.sgi.com
Subject: Re: [PATCH 2/3] xfs: introduce per-inode DAX enablement
Date: Mon, 15 Feb 2016 17:44:13 -0600 [thread overview]
Message-ID: <56C262CD.9030701@sandeen.net> (raw)
In-Reply-To: <1455514346-15481-3-git-send-email-david@fromorbit.com>
On 2/14/16 11:32 PM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Source kernel commit 58f88ca2df7270881de2034c8286233a89efe71c
>
> Rather than just being able to turn DAX on and off via a mount
> option, some applications may only want to enable DAX for certain
> performance critical files in a filesystem.
>
> This patch introduces a new inode flag to enable DAX in the v3 inode
> di_flags2 field. It adds support for setting and clearing flags in
> the di_flags2 field via the XFS_IOC_FSSETXATTR ioctl, and sets the
> S_DAX inode flag appropriately when it is seen.
>
> When this flag is set on a directory, it acts as an "inherit flag".
> That is, inodes created in the directory will automatically inherit
> the on-disk inode DAX flag, enabling administrators to set up
> directory heirarchies that automatically use DAX. Setting this flag
> on an empty root directory will make the entire filesystem use DAX
> by default.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> Signed-off-by: Dave Chinner <david@fromorbit.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> libxfs/xfs_format.h | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/libxfs/xfs_format.h b/libxfs/xfs_format.h
> index 967b1ef..7eae0a5 100644
> --- a/libxfs/xfs_format.h
> +++ b/libxfs/xfs_format.h
> @@ -1024,6 +1024,15 @@ static inline void xfs_dinode_put_rdev(struct xfs_dinode *dip, xfs_dev_t rdev)
> XFS_DIFLAG_EXTSZINHERIT | XFS_DIFLAG_NODEFRAG | XFS_DIFLAG_FILESTREAM)
>
> /*
> + * Values for di_flags2 These start by being exposed to userspace in the upper
> + * 16 bits of the XFS_XFLAG_s range.
> + */
> +#define XFS_DIFLAG2_DAX_BIT 0 /* use DAX for this inode */
> +#define XFS_DIFLAG2_DAX (1 << XFS_DIFLAG2_DAX_BIT)
> +
> +#define XFS_DIFLAG2_ANY (XFS_DIFLAG2_DAX)
> +
> +/*
> * Inode number format:
> * low inopblog bits - offset in block
> * next agblklog bits - block number in ag
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-02-15 23:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-15 5:32 [PATCH 0/3] xfsprogs: FS_IOC_FS[SG]ETXATTR and DAX support Dave Chinner
2016-02-15 5:32 ` [PATCH 1/3] xfs_fs.h: XFS_IOC_FS[SG]SETXATTR to FS_IOC_FS[SG]ETXATTR promotion Dave Chinner
2016-02-15 23:43 ` Eric Sandeen
2016-02-15 5:32 ` [PATCH 2/3] xfs: introduce per-inode DAX enablement Dave Chinner
2016-02-15 23:44 ` Eric Sandeen [this message]
2016-02-15 5:32 ` [PATCH 3/3] xfs_io: add support for changing the new inode DAX attribute Dave Chinner
2016-02-15 23:46 ` Eric Sandeen
2016-02-17 22:53 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C262CD.9030701@sandeen.net \
--to=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox