From: Luis de Bethencourt <luisbg@osg.samsung.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: cmaiolino@redhat.com, darrick.wong@oracle.com,
namjae.jeon@samsung.com, bfoster@redhat.com, sandeen@sandeen.net,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com,
billodo@redhat.com
Subject: Re: [PATCH] xfs: remove impossible condition
Date: Tue, 01 Mar 2016 13:23:33 +0000 [thread overview]
Message-ID: <56D597D5.3040002@osg.samsung.com> (raw)
In-Reply-To: <20160301120814.GA5217@infradead.org>
On 01/03/16 12:08, Christoph Hellwig wrote:
> On Thu, Feb 25, 2016 at 12:43:57PM +0000, Luis de Bethencourt wrote:
>> bp_release is set to 0 just before the breakpoint of the for loop before
>> the conditional check (in line 458). The other breakpoint is a goto that
>> skips the dead code.
>
> Yes, this looks correct:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> The whole code around this is rather grotty and could use some more
> work, though..
>
Thanks for the review Christoph!
If you have some specific things in mind that I could fix in the code around
this, I am happy to add it to my ToDo list. Or I can continue reading it and
let you know of anything I see, so you can confirm before I try to fix it.
Regards,
Luis
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-03-01 13:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 12:43 [PATCH] xfs: remove impossible condition Luis de Bethencourt
2016-03-01 12:08 ` Christoph Hellwig
2016-03-01 13:23 ` Luis de Bethencourt [this message]
2016-03-01 18:22 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D597D5.3040002@osg.samsung.com \
--to=luisbg@osg.samsung.com \
--cc=bfoster@redhat.com \
--cc=billodo@redhat.com \
--cc=cmaiolino@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox