public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@redhat.com>
To: xfs@oss.sgi.com
Cc: Al Viro <viro@ZenIV.linux.org.uk>
Subject: ASSERT in xlog_find_verify_log_record during xfs/098
Date: Tue, 1 Mar 2016 13:04:58 -0600	[thread overview]
Message-ID: <56D5E7DA.3080900@redhat.com> (raw)

Al mentioned that he hit an ASSERT during xfs/098, a log fuzzer
test, in xlog_find_verify_log_record():


        for (i = (*last_blk) - 1; i >= 0; i--) {
                if (i < start_blk) {
                        /* valid log record not found */
                        xfs_warn(log->l_mp,
                "Log inconsistent (didn't find previous header)");
                        ASSERT(0);
                        error = -EIO;
                        goto out;
                }

Should that assert even be there?  Looks like it's gracefully
handled, I don't see offhand that anything should have caught
this corruption earlier, and we don't really want to bug on disk
corruption.  Am I missing something?

Thanks,
-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

             reply	other threads:[~2016-03-01 19:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-01 19:04 Eric Sandeen [this message]
2016-03-01 20:45 ` ASSERT in xlog_find_verify_log_record during xfs/098 Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D5E7DA.3080900@redhat.com \
    --to=sandeen@redhat.com \
    --cc=viro@ZenIV.linux.org.uk \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox