From: Eric Sandeen <sandeen@sandeen.net>
To: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: add missing break in xfs_parseargs()
Date: Thu, 31 Mar 2016 10:04:41 -0500 [thread overview]
Message-ID: <56FD3C89.1080400@sandeen.net> (raw)
In-Reply-To: <1459415583-26981-1-git-send-email-guaneryu@gmail.com>
On 3/31/16 4:13 AM, Eryu Guan wrote:
> Commit 2e74af0e1189 ("xfs: convert mount option parsing to tokens")
> missed a 'break;' in xfs_parseargs() which causes mount to fail with
> "-o pqnoenforce" option. xfs/050 catches this failure.
>
> XFS (vda6): Super block does not support project and group quota together
>
> Fixes: 2e74af0e1189 ("xfs: convert mount option parsing to tokens")
> Signed-off-by: Eryu Guan <guaneryu@gmail.com>
Ugh, how did I miss that; I thought I scripted that whole change.
Thanks for catching it!
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> fs/xfs/xfs_super.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index d760934..361564e 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -350,6 +350,7 @@ xfs_parseargs(
> case Opt_pqnoenforce:
> mp->m_qflags |= (XFS_PQUOTA_ACCT | XFS_PQUOTA_ACTIVE);
> mp->m_qflags &= ~XFS_PQUOTA_ENFD;
> + break;
> case Opt_gquota:
> case Opt_grpquota:
> mp->m_qflags |= (XFS_GQUOTA_ACCT | XFS_GQUOTA_ACTIVE |
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2016-03-31 15:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 9:13 [PATCH] xfs: add missing break in xfs_parseargs() Eryu Guan
2016-03-31 11:14 ` Eryu Guan
2016-03-31 14:52 ` Brian Foster
2016-03-31 15:04 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FD3C89.1080400@sandeen.net \
--to=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox